Bug 271932
| Summary: | ASUS_AC1300 fails to compile qcom_cpu_kpassv2.c | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Mina Galić <freebsd> |
| Component: | arm | Assignee: | Warner Losh <imp> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | marklmi26-fbsd |
| Priority: | --- | Flags: | imp:
mfc-stable13-
|
| Version: | CURRENT | ||
| Hardware: | arm | ||
| OS: | Any | ||
| URL: | https://github.com/freebsd/freebsd-src/pull/776 | ||
|
Description
Mina Galić
2023-06-10 06:22:04 UTC
A little context not shown by the error messages:
sys/arm/qualcomm/qcom_cpu_kpssv2.c still has (from back in
2021-Oct):
boolean_t
qcom_cpu_kpssv2_regulator_start(u_int id, phandle_t node)
{
. . .
sys/arm/qualcomm/qcom_cpu_kpssv2.h recently got an update
to ( afdb42987ca8 ):
extern bool qcom_cpu_kpssv2_regulator_start(u_int id, phandle_t node);
bool vs. boolean_t need not be compatible. boolean_t needs
to be replaced.
thanks for the analysis. I'll be able to submit a patch one I'm at the computer tonight A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3ed646d89aa4a312ceb1bdcb948f91903860f8f0 commit 3ed646d89aa4a312ceb1bdcb948f91903860f8f0 Author: Mina Galić <freebsd@igalic.co> AuthorDate: 2023-06-11 21:12:59 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-06-12 14:30:15 +0000 fix qcom_cpu_kpssv2 compile on ASUS_AC1300 Complete afdb42987ca8 by changing the return type from boolean_t to bool for the definition for qcom_cpu_kpssv2_regulator_start. PR: 271932 Fixes: afdb42987ca82869eeaecf6dc25c2b6fb7b8370e Pull Request: https://github.com/freebsd/freebsd-src/pull/776 sys/arm/qualcomm/qcom_cpu_kpssv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^Triage: assign to committer that resolved. Not relevant to 13. |
