Bug 271980

Summary: audio/aubio: unbreak build with python 3.11+ (+)
Product: Ports & Packages Reporter: Dima Panov <fluffy>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Some People Flags: jhale: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[PATCH] audio/aubio: unbreak build with python 3.11+ (+) none

Description Dima Panov freebsd_committer freebsd_triage 2023-06-13 13:02:11 UTC
Created attachment 242761 [details]
[PATCH] audio/aubio: unbreak build with python 3.11+ (+)

[PATCH] audio/aubio: unbreak build with python 3.11+ (+)

Python have set default and deprecated flag 'U' (open as Unicode)
for all file open routines since 3.3 release and removed it in 3.11+

Move post-patch rules out of !SLAVE_PORT section to common part because
audio/py-aulib also needs these fixes

Reported by:    poudriere fallout
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2023-06-13 16:42:22 UTC
(In reply to Dima Panov from comment #0)

Thanks! I'm not sure why it would be necessary to move the post-patch target out of the !SLAVE_PORT section, though. The patches are just fixing waf and py-aubio doesn't use waf to build, just the master aubio port.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2023-06-13 16:51:07 UTC
(In reply to Jason E. Hale from comment #1)
Just being cautious with patching slave port too after some (may be independed due to recent pythons bump) failures in pou :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-15 15:51:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ec162a92706e35bee060393f83a3c887f021259

commit 1ec162a92706e35bee060393f83a3c887f021259
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2023-06-13 12:43:24 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-06-15 15:50:33 +0000

    audio/aubio: unbreak build with python 3.11+

    Python has set as default and deprecated the 'U' (open as Unicode) flag
    for all file open routines since 3.3 release and removed it in 3.11+.

    PR:             271980

 audio/aubio/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2023-06-15 15:57:11 UTC
Committed, thanks! I did a poudriere run with python 3.11 as the default version and py-aubio built fine without the patch, so moved the post-patch target back where it was.
Comment 5 Dima Panov freebsd_committer freebsd_triage 2023-06-15 16:08:14 UTC
(In reply to Jason E. Hale from comment #4)
Yeah, thanks for additional runs. False positivities are obey :)