Bug 272102

Summary: www/deno: panics a lot in dprint-swc-ext (needs update)
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Some People CC: grahamperrin
Priority: --- Keywords: crash
Version: LatestFlags: bugzilla: maintainer-feedback? (mikael)
Hardware: Any   
OS: Any   
URL: https://github.com/denoland/deno/releases/tag/v1.34.3
Attachments:
Description Flags
0001-www-deno-update-to-1.34.3.patch
val: maintainer-approval?
retrieve rss with sysctl
none
disable upgrade none

Description Val Packett 2023-06-20 18:57:43 UTC 
The currently packaged 1.34.1 is a really unfortunate version because very often  it crashes with this:

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: freebsd x86_64
Version: 1.34.1
Args: ["deno", "run", "--allow-all", "build.ts"]

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /wrkdirs/usr/ports/www/deno/work/deno-1.34.1/cargo-crates/dprint-swc-ext-0.9.0/src/view
/generated.rs:12430:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


In the current v1.34.3 that dependency has been updated to dprint-swc-ext-0.10.0 which should fix that..
Comment 2 Val Packett 2023-06-21 07:29:18 UTC 
Created attachment 242913 [details]
0001-www-deno-update-to-1.34.3.patch

Here's a patch!
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2023-06-21 08:07:41 UTC 
Created attachment 242914 [details]
retrieve rss with sysctl

(In reply to Val Packett from comment #2)
Thanks, I was updating the port on my side.

Do you have time to review the attached file? it's based on OpenBSD's code.
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2023-06-21 08:09:28 UTC 
Created attachment 242915 [details]
disable upgrade

and this one too.
Comment 5 Val Packett 2023-06-21 08:11:53 UTC 
both LGTM
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-06-21 11:36:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44fc0f1cf985d7982ff549f26cb5a8b98fc1120f

commit 44fc0f1cf985d7982ff549f26cb5a8b98fc1120f
Author:     Val Packett <val@packett.cool>
AuthorDate: 2023-06-21 07:12:38 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-06-21 11:35:21 +0000

    www/deno: update to 1.34.3

    Important update due to dprint-swc-ext dependency bump fixing a panic.
    While here, avoid bringing in the rayon dependency via sysinfo.

    Changelog:      https://github.com/denoland/deno/compare/v1.34.1...v1.34.3
    PR:             272102
    Sponsored by:   https://www.patreon.com/valpackett

 www/deno/Makefile                                  | 109 ++++++-----
 www/deno/distinfo                                  | 214 +++++++++++----------
 www/deno/files/patch-Cargo.lock                    |  98 +---------
 ...rgo-crates_libffi-sys-2.2.1_build_not__msvc.rs} |   4 +-
 www/deno/files/patch-ext_fs_30__fs.js (gone)       |  20 --
 www/deno/files/patch-ext_fs_std__fs.rs (gone)      |  11 --
 www/deno/files/patch-runtime_Cargo.toml            |   2 +-
 www/deno/files/patch-tools_wpt_utils.ts (gone)     |  10 -
 8 files changed, 177 insertions(+), 291 deletions(-)