Bug 272167
| Summary: | print/cups: Use upstream release tarball | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Tijl Coosemans <tijl> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | freebsd | ||||
| Priority: | --- | Flags: | tijl:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Ok, but maybe use DISTVERSIONSUFFIX=-source instead of DISTNAME? I would say no as it's not a part of the "version name" imo but the filename itself however looking at "Example 7. Using DISTVERSION" I guess it's up to the maintainer to decide. If we're going to be picky about style PORTVERSION should also be DISTVERSION (I missed that when I generated the patch). (In reply to Daniel Engberg from comment #2) Okay, how about DISTVERSION=2.4.6 and EXTRACT_SUFX=-source.tar.gz? That works but Porters Handbook suggests that using it that way is misusing the variable. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-extract_sufx A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=21e620488c1e545a0af680a7c5d1aecc50fd04ce commit 21e620488c1e545a0af680a7c5d1aecc50fd04ce Author: Tijl Coosemans <tijl@FreeBSD.org> AuthorDate: 2023-06-25 16:01:29 +0000 Commit: Tijl Coosemans <tijl@FreeBSD.org> CommitDate: 2023-07-11 20:10:57 +0000 print/cups: Use upstream release tarball PR: 272167 print/cups/Makefile | 8 +++----- print/cups/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 8 deletions(-) |
Created attachment 242956 [details] Patch for cups As recommened by Porters Handbook use release tarball instead of using USE_GITHUB Tested on 13.2-RELEASE (amd64)