Bug 272279

Summary: net-mgmt/netdata: ML option fails to compile on 1.40.1
Product: Ports & Packages Reporter: Trond Endrestøl <Trond.Endrestol>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, nk
Priority: --- Flags: bugzilla: maintainer-feedback? (nk)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for netdata none

Description Trond Endrestøl 2023-06-29 09:24:55 UTC 
Enabling the ML option leads to:

gmake[3]: *** No rule to make target 'ml/dlib/dlib/all/source.cpp', needed by 'ml/dlib/dlib/all/source.o'.  Stop.
gmake[3]: *** Waiting for unfinished jobs....
gmake[3]: Leaving directory '/construction/xports/net-mgmt/netdata/work/netdata-v1.40.1'

It turns out ml/dlib/dlib/all/ contains only a .deps directory.

After fumbling for a while I figured we simply need to extract the dlib-cpp distribution in the ml/dlib/ hierarchy.
Comment 1 Trond Endrestøl 2023-06-29 09:34:08 UTC 
(In reply to Trond.Endrestol from comment #0)
Or change Makefile.in to skip compiling dlib-cpp and simply link the executable to the library.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-06-30 02:10:12 UTC 
Created attachment 243079 [details]
Patch for netdata

Looks like this patch got lost during rebasing, please give it a spin
Comment 3 Trond Endrestøl 2023-07-03 08:12:43 UTC 
(In reply to Daniel Engberg from comment #2)
Patch is successful. Please commit it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-12 02:31:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17d819351f980301b6ebe99d3865c211a290d67f

commit 17d819351f980301b6ebe99d3865c211a290d67f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-07-05 18:55:25 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-07-12 02:30:20 +0000

    net-mgmt/netdata: Fix ML option

    Fix option that accidently broke during rebase

    PR:             272279
    Reported by:    Trond Endrestol <Trond.Endrestol@ximalas.info>
    Tested by:      Trond Endrestol <Trond.Endrestol@ximalas.info>
    Reviewed by:    Namkhai B <me@forkbomb9.ch> (private email)

 net-mgmt/netdata/files/patch-Makefile.am (new) | 29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-07-12 02:31:32 UTC 
Fixed, thanks for testing!