Bug 272309

Summary: multimedia/kodi: Update to 20.2
Product: Ports & Packages Reporter: yzrh <yzrh>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: decke, fuz
Priority: --- Flags: fuz: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/xbmc/xbmc/releases/tag/20.2-Nexus
Attachments:
Description Flags
kodi 20.2
none
testport log (bzip2)
none
devel/kodi-platform fix none

Description yzrh 2023-07-01 08:42:09 UTC
Created attachment 243094 [details]
kodi 20.2
Comment 1 yzrh 2023-07-01 08:42:34 UTC
Created attachment 243095 [details]
testport log (bzip2)
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-07-01 12:18:08 UTC
Is there a changelog for this update?
Comment 3 yzrh 2023-07-01 19:21:46 UTC
As a maintenance release, it contains no new features, just bug fixes and backports.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-07-01 23:45:54 UTC
Thanks.  MFH to 2023Q3 should be appropriate.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-07-02 11:40:01 UTC
The makefile says:

    # do not forget to fix devel/kodi-platform when updating kodi

However, I do not see any update for devel/kodi-platform in your patch.  Is this correct?
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-07-02 22:02:09 UTC
devel/kodi-platform fails to package following your update:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libkodiplatform.so.20.2.0
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libkodiplatform.so.20.1.0
===> Error: Plist issues found.

Please check and resubmit.

When updating a port on which other ports depend, always make sure to test the ports that depend on it!  If there are too many ports for you to check, you can request an exp-run.
Comment 7 yzrh 2023-07-03 21:17:50 UTC
Okay, usually maintainer of devel/kodi-platform (decke@FreeBSD.org) will
fix pkg-plist after any kodi update. We have had a conversation about
how to coordinate kodi updates across all add-ons and kodi-platform.
After some time, for major version, he will commit add-ons and kodi together,
for minor version, he will fix pkg-plist (of devel/kodi-platform) at a later
time. Maybe I should add him to CC list.
Comment 8 yzrh 2023-07-03 21:28:29 UTC
Created attachment 243188 [details]
devel/kodi-platform fix

I just notice the CC list.  Does the patch look right?
By the way, thanks for looking after add-ons.
Comment 9 Bernhard Froehlich freebsd_committer freebsd_triage 2023-07-04 04:09:55 UTC
Patch for kodi-platform looks good to me.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-07-05 17:26:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0768c73262fefb0770599ea272817e4c3c15b754

commit 0768c73262fefb0770599ea272817e4c3c15b754
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2023-07-02 11:38:45 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-05 17:25:12 +0000

    multimedia/kodi: update to 20.2

    Changelog: https://github.com/xbmc/xbmc/releases/tag/20.2-Nexus

    PR:             272309
    MFH:            2023Q3

 multimedia/kodi/Makefile | 6 +-----
 multimedia/kodi/distinfo | 8 +++-----
 2 files changed, 4 insertions(+), 10 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-07-05 17:26:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a72c29a36de0f6760fc6005b2ffdbca7f55bc24

commit 2a72c29a36de0f6760fc6005b2ffdbca7f55bc24
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2023-07-03 21:50:30 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-05 17:25:13 +0000

    devel/kodi-platform: fix plist following kodi update

    PR:             272309
    Approved by:    decke (maintainer)

 devel/kodi-platform/Makefile  | 2 +-
 devel/kodi-platform/pkg-plist | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-07-05 17:27:28 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca95b79fb15dc98978d21c6d97148a7f621bec09

commit ca95b79fb15dc98978d21c6d97148a7f621bec09
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2023-07-02 11:38:45 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-05 17:26:52 +0000

    multimedia/kodi: update to 20.2

    Changelog: https://github.com/xbmc/xbmc/releases/tag/20.2-Nexus

    PR:             272309
    MFH:            2023Q3
    (cherry picked from commit 0768c73262fefb0770599ea272817e4c3c15b754)

 multimedia/kodi/Makefile | 6 +-----
 multimedia/kodi/distinfo | 8 +++-----
 2 files changed, 4 insertions(+), 10 deletions(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2023-07-05 17:27:32 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf8c260a35d6f1b301356ae1b553df5e7be1ff0b

commit bf8c260a35d6f1b301356ae1b553df5e7be1ff0b
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2023-07-03 21:50:30 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-05 17:26:53 +0000

    devel/kodi-platform: fix plist following kodi update

    PR:             272309
    Approved by:    decke (maintainer)

    (cherry picked from commit 2a72c29a36de0f6760fc6005b2ffdbca7f55bc24)

 devel/kodi-platform/Makefile  | 2 +-
 devel/kodi-platform/pkg-plist | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2023-07-06 06:52:48 UTC
Thank you for your contribution.