Bug 272370

Summary: Corrupt commit e-mail notifications are sent
Product: Services Reporter: Yuri Victorovich <yuri>
Component: Core InfrastructureAssignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Many People CC: grahamperrin, lwhsu, philip
Priority: ---    
Version: unspecified   
Hardware: Any   
OS: Any   
URL: https://lists.freebsd.org/archives/dev-commits-ports-all/2023-July/070669.html

Description Yuri Victorovich freebsd_committer freebsd_triage 2023-07-04 19:57:40 UTC
The e-mail notification about my today's ports commit 4713ff4d269008312a404633ec2954e35ce118ce came corrupt. Here is a source fragment of the corrupt message:

> Date: Tue, 4 Jul 2023 19:48:13 GMT
> Message-Id: <202307041948.364JmD3B046666@gitrepo.freebsd.org>
> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
>         dev-commits-ports-main@FreeBSD.org
> From: Yuri Victorovich <yuri@FreeBSD.org>
> Subject: git: 4713ff4d2690 - main - =?utf-8?Q?science/py-emmet-core:=20Update=200.58.0=20=E2=86=92=200.58.1;=20Break=20dependency=20c=
> Precedence: bulk
> X-Loop: FreeBSD.org
> Sender: owner-ports-committers@freebsd.org
> List-Id: FreeBSD mail <ports-committers.freebsd.org>
> X-Greylist: inspected by milter-greylist-4.6.4 (mail0.rawbw.com [198.144.192.41]); Tue, 04 Jul 2023 12:48:20 -0700 (PDT) for IP:'96.47.72.81' DOMAIN:'mx2.freebsd.org' HELO:'mx2.freebsd.org' FROM:'owner-ports-committers@freebsd.org' RCPT:''
> 
> ircle?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: 8bit
> X-Git-Committer: yuri
> X-Git-Repository: ports
> X-Git-Refname: refs/heads/main
> X-Git-Reftype: branch
> X-Git-Commit: 4713ff4d269008312a404633ec2954e35ce118ce
> Auto-Submitted: auto-generated


Please note that the Subject line contains some garbage, etc.

This happened several times before, for example for commits 68180db8a599c5918bc59df1270eb0fb1be6b64a and 5b0b2ae1d26804998a6ad8714b4e5f3697f4d99f.
Comment 1 Philip Paeps freebsd_committer freebsd_triage 2023-07-05 01:26:56 UTC
I think what you call "garbage" is simply the RFC 2047 encoding of "→".

The actual problem is the newline after 125 characters of subject.  I'll take a look.  Thanks for reporting.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-07-05 01:33:47 UTC
(In reply to Philip Paeps from comment #1)

Not all messages containing "→" get corrupted, only some of them.
Comment 3 Philip Paeps freebsd_committer freebsd_triage 2023-07-05 01:37:48 UTC
Indeed.  It looks like a line length thing.

This got an extra newline:
science/py-emmet-core: Update 0.58.0 → 0.58.1; Break dependency circle

This did not:
devel/sdl20: update 2.28.0 → 2.28.1
Comment 4 Philip Paeps freebsd_committer freebsd_triage 2023-07-05 04:57:59 UTC
I think I've fixed this.  I'll ask others on clusteradm to review the change before putting it into production.
Comment 5 Li-Wen Hsu freebsd_committer freebsd_triage 2023-08-08 20:30:32 UTC
Philip's fix has been verified and deployed.