Bug 272477

Summary: www/tor-browser: about:manual file not found
Product: Ports & Packages Reporter: Graham Perrin <grahamperrin>
Component: Individual Port(s)Assignee: Jesper Schmitz Mouridsen <jsm>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape, freebsd, grahamperrin, jsm
Priority: --- Flags: bugzilla: maintainer-feedback? (freebsd)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.freshports.org/www/tor-browser/
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273416

Description Graham Perrin freebsd_committer freebsd_triage 2023-07-12 21:14:59 UTC
1. run tor-browser

2. connect

3. Check our Tor Browser Manual »

Firefox can’t find the file at jar:file:///usr/local/lib/tor-browser/browser/omni.ja!/chrome/browser/content/browser/manual/en.html.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-15 11:44:52 UTC
^Triage: reporter is committer, assign accordingly.
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2023-07-16 18:49:53 UTC
Sorry, ports work such as this is out of scope for me.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-17 06:47:54 UTC
(In reply to Graham Perrin from comment #2)
I really don't see being the assignee of a PR as the person that needs to fix the issue described in it.
IMHO the assignee is the person that drives the effort in the PR so it can be moved forward and (with any luck) be closed successfully.
This would mean contacting the appropriate people, talking to the maintainer or other users, asking for more information, be willing to test proposed patches, etc.
Comment 4 Graham Perrin 2023-09-18 22:54:05 UTC
Re: comment 0

> Firefox can’t find the file at 
> jar:file:///usr/local/lib/tor-browser/browser/omni.ja!/chrome/browser/content/browser/manual/en.html.

% pwd
/usr/local/lib/tor-browser/browser
% ls -hln
total 13
drwxr-xr-x  3 0 0    3B 26 Dec  2022 chrome
drwxr-xr-x  2 0 0    3B 17 Sep 04:13 features
-rw-r--r--  1 0 0   39M 14 Sep 03:14 omni.ja
% file ./omni.ja
./omni.ja: Zip archive data, at least v1.0 to extract, compression method=store
% pkg iinfo tor-browser
tor-browser-12.0.6_4
% 


Indirectly via <https://mike.kaply.com/2013/05/06/dont-unpack-and-repack-omni-jar/>, captured (no longer available):

<https://web.archive.org/web/20210620190432/https://developer.mozilla.org/en-US/docs/Mozilla/About_omni.ja_%28formerly_omni.jar%29>

> omni.ja (formerly omni.jar) - Mozilla | MDN
Comment 5 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-10-21 14:21:24 UTC
I added the manual in the proposed patch for 13.0 in #bug 273416
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-11-09 19:40:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5bab21c20a580787a9906f4012743287141878d8

commit 5bab21c20a580787a9906f4012743287141878d8
Author:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
AuthorDate: 2023-11-09 19:16:52 +0000
Commit:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
CommitDate: 2023-11-09 19:39:10 +0000

    www/tor-browser: Update to 13.01

       Include locales upfront, the LOCAL/jsm l10n distfile is made
       by a tor-browser-build of project l10n-firefox.

       The tpo/translations do not keep tags so two files per locale
       are out of sync with the linux release.

    PR:     273416
    PR:     272477
    Tested by:      Martin Filla freebsd@sysctl.cz,rene@
    Approved by:    freebsd@sysctl.cz (maintainer)

 www/tor-browser/Makefile                           |    65 +-
 www/tor-browser/distinfo                           |    14 +-
 www/tor-browser/files/packagemanual.py (new)       |    69 +
 www/tor-browser/files/patch-addon-search           |    24 +-
 .../files/patch-browser-app-nsBrowserApp.cpp       |    14 +-
 .../files/patch-browser-base-jar.mn (new)          |   227 +
 .../patch-browser_app_profile_000-tor-browser.js   |    16 +-
 www/tor-browser/files/patch-bug1427152 (new)       |    10 +
 www/tor-browser/files/patch-bug1504834_comment5    |    10 +-
 .../files/patch-bug1504834_comment9 (gone)         |    49 -
 www/tor-browser/files/patch-bug1559213             |    39 +-
 www/tor-browser/files/patch-bug1626236             |    40 +-
 www/tor-browser/files/patch-bug1628567             |     4 +-
 www/tor-browser/files/patch-bug1640982 (gone)      |    17 -
 www/tor-browser/files/patch-bug1659612             |    22 +-
 www/tor-browser/files/patch-bug1664115 (gone)      |    82 -
 .../files/patch-bug1729459_comment12 (gone)        |    93 -
 www/tor-browser/files/patch-bug847568              |    10 +-
 .../patch-gfx_skia_skia_src_base_SkEndian.h (new)  |    11 +
 ...gfx_skia_skia_src_core_SkRasterPipeline.h (new) |    11 +
 .../files/patch-i386-protobuf-alignment (new)      |    15 +
 .../files/patch-js_public_Utility.h (new)          |    35 +
 .../files/patch-libwebrtc-generate (gone)          |   159 -
 www/tor-browser/files/patch-libwebrtc-generated    | 50556 ++++++++++++++-----
 .../files/patch-libwebrtc-powerpc64 (new)          |   264 +
 .../files/patch-memory_mozalloc_throw__gcc.h       |     2 +-
 .../patch-modules_fdlibm_src_math__private.h (new) |    27 +
 www/tor-browser/files/patch-pipewire_init          |    67 +-
 ...patch-python_mozbuild_mozbuild_gn__processor.py |    21 +-
 www/tor-browser/files/patch-rust-1.70.0 (gone)     |    33 -
 www/tor-browser/files/patch-rust-1.73.0 (gone)     |    83 -
 ...rty_libwebrtc_build_config_BUILDCONFIG.gn (new) |    37 +
 ..._party_libwebrtc_rtc__base_ip__address.cc (new) |    23 +
 ...omponents_tor-launcher_TorProcess_sys_mjs (new) |    26 +
 ...nonents_tor-launcher_TorLauncherUtil.jsm (gone) |    20 -
 ...compononents_tor-launcher_TorProcess.jsm (gone) |    22 -
 .../files/patch-toolkit_torbutton_jar.mn (new)     |    80 +
 .../files/patch-toolkit_xre_glxtest.cpp (new)      |    17 +
 .../patch-toolkit_xre_nsXREDirPRovider.cpp (gone)  |    14 -
 39 files changed, 39157 insertions(+), 13171 deletions(-)