Bug 272703

Summary: java/intellij-fsnotifier: Update to 20230112
Product: Ports & Packages Reporter: Erik Jensen <erik>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://gitlab.com/worthwhileit/bsd/fsnotifier
Attachments:
Description Flags
Patch for update to 20230112
erik: maintainer-approval+
Patch with GL_TAGNAME instead of GL_COMMIT erik: maintainer-approval+

Description Erik Jensen 2023-07-24 21:55:29 UTC 
Created attachment 243598 [details]
Patch for update to 20230112

Volunteering to be the new maintainer of this port.

New repository here: https://gitlab.com/worthwhileit/bsd/fsnotifier

Excerpt from README in new repository:
"Adaptation of JetBrains' fsNotifier (https://github.com/JetBrains/intellij-community/tree/master/native/fsNotifier/linux) to work on FreeBSD, largely inspired by the modifications made by the user t6 at the (now 404'd) GitHub repository (https://github.com/t6/fsnotifier) by the name of fsnotifier."

This patch to the port merges t6's modifications into the latest version of JetBrains' fsNotifier, and it provides both a dynamically as well as a statically linked executable, `fsnotifier{,-static}`.
In addition, the number of open file descriptors allowed on a given system is now inferred and handled properly by the executables.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-25 07:37:57 UTC 
Hi Erik,

Thanks for the patch.

Could you change this, if possible?

===== env: DEVELOPER_MODE=yes DEVELOPER=1 STRICT_DEPENDS=yes USER=nobody UID=65534 GID=65534
/!\ intellij-fsnotifier-20230112: Makefile warnings, please consider fixing /!\                                                                                 

GL_COMMIT is deprecated, please use GL_TAGNAME instead
Comment 2 Erik Jensen 2023-07-25 12:12:12 UTC 
Created attachment 243608 [details]
Patch with GL_TAGNAME instead of GL_COMMIT

Hi Fernando,

I would much prefer to use GL_TAGNAME=${PORTVERSION} over GL_COMMIT, but is it compatible with the quarterly branch?
I can only find mention of GL_TAGNAME in my 'latest' ports tree.

In case this is not a concern, I attach here a patch with GL_TAGNAME instead of GL_COMMIT.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-25 15:00:11 UTC 
Committed,

I think we are good for now.

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-25 15:11:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df0f45d5120b5d2e8f73e2edb54279bdc8ee5c9b

commit df0f45d5120b5d2e8f73e2edb54279bdc8ee5c9b
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2023-07-25 07:04:57 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-07-25 15:10:15 +0000

    java/intellij-fsnotifier: Update to 20230112

    ChangeLog: https://gitlab.com/worthwhileit/bsd/fsnotifier

    "Adaptation of JetBrains' fsNotifier
    (https://github.com/JetBrains/intellij-community/tree/master/native/fsNotifier/linux)
    to work on FreeBSD, largely inspired by the modifications made by the user t6 at
    the (now 404'd) GitHub repository (https://github.com/t6/fsnotifier) by the name
    of fsnotifier."

    PR:             272703
    Reported by:    erik@tenku.dk (maintainer)

 java/intellij-fsnotifier/Makefile        | 25 ++++++++++---------------
 java/intellij-fsnotifier/distinfo        |  6 +++---
 java/intellij-fsnotifier/pkg-plist (new) | 10 ++++++++++
 3 files changed, 23 insertions(+), 18 deletions(-)