Bug 272722

Summary: devel/tig invalid pattern in LIB_DEPENDS
Product: Ports & Packages Reporter: mord0d
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Only Me CC: 0mp, jcfyecrayz
Priority: --- Flags: bugzilla: maintainer-feedback? (0mp)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tig-2.5.8.log
none
[patch] devel/tig: fix bad LIB_DEPENDS for PCRE option jcfyecrayz: maintainer-approval? (0mp)

Description mord0d 2023-07-25 16:08:18 UTC
Created attachment 243614 [details]
tig-2.5.8.log

Error: pattern lpcre2-posix.so in LIB_DEPENDS is not valid
Comment 1 John Hein 2023-08-08 14:10:53 UTC
Created attachment 243969 [details]
[patch] devel/tig: fix bad LIB_DEPENDS for PCRE option

This was my fault in the patch in bug 270362 (only affects the non-default PCRE option).  I noticed it a couple weeks ago and fixed it locally, but I forgot to submit the fix.

It's attached now.  Sorry for the original error and the delay in submitting this fix.  As it is a non-default option, I hope few were affected.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2023-08-08 19:43:23 UTC
Thanks for the report and the patch! I'll fix that in a moment.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-08-08 19:45:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7b92e72aa4c3cf5b105b2426fdbd2ed7625a6498

commit 7b92e72aa4c3cf5b105b2426fdbd2ed7625a6498
Author:     John Hein <jcfyecrayz@liamekaens.com>
AuthorDate: 2023-08-08 19:42:16 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2023-08-08 19:42:16 +0000

    devel/tig: Fix the dependencies of the PCRE option

    PR:             272722
    Reported by:    mord0d@firemail.cc

 devel/tig/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2023-08-08 19:46:55 UTC
I've committed the fix. Thanks!