Bug 272727

We also could have it with both platforms enabled:

For example, on a x86_64 linux system that supports both 64-bit and 32-bit executables, you might specify --with-boinc-platform=x86_64-pc-linux-gnu and --with-boinc-alt-platform=i686-pc-linux-gnu.

Just not sure whether it could be of any use, as even if some BOINC projects still have 32-bit executables, they are very likely to have 64-bit ones too, which perform better. And whether Linuxulator subsystem would be able to run 32 bit Linux executables?

What else could we do with it: some kind of platform autodetection? Or manual selection via Makefile flags? This patch is just a simplest working solution, but what could the best one look like?

Created attachment 243858 [details]
[PATCH] net/boinc-client: Change alternate platform to x86_64-pc-linux-gnu

Created attachment 243865 [details]
[PATCH] net/boinc-client: Change alternate platform to x86_64-pc-linux-gnu

Comment on attachment 243865 [details]
[PATCH] net/boinc-client: Change alternate platform to x86_64-pc-linux-gnu

Maintainer timeout

Fixed with commit for bug #252273.

I have a simple patch for this now.

Created attachment 251307 [details]
[PATCH] net/boinc-client: configure alternate platform according to ${ARCH}

Comment 8 Vladimir Druzenko 2025-01-27 23:40:52 UTC

Maintainer timeout > 18 months.

Is port support other arch(7)-es: armv7, armv6, powerpcspe, powerpc64le, riscv64?

Comment 9 Vladimir Druzenko 2025-01-27 23:55:23 UTC

FreeBSD ports support Linux only on amd64, i386 and aarch64 for rl9 (Rocky Linux 9) and on amd64 and i386 for c7 (CentOS 7).
Check Mk/Uses/linux.mk.

-OPTIONS_DEFINE=         CLIENT LINUX MANAGER NLS SKINS USER X11
+OPTIONS_DEFINE=         CLIENT MANAGER NLS SKINS USER X11
+OPTIONS_DEFINE_amd64=   LINUX
+OPTIONS_DEFINE_aarch64= LINUX
+OPTIONS_DEFINE_i386=    LINUX

+# https://boinc.berkeley.edu/trac/wiki/BoincPlatforms
+.if ${ARCH} == "amd64"
+BOINC_ALT_PLATFORM=	x86_64-pc-linux-gnu
+.elif ${ARCH} == "aarch64"
+BOINC_ALT_PLATFORM=	aarch64-unknown-linux-gnu
+.elif ${ARCH} == "i386"
+BOINC_ALT_PLATFORM=	i686-pc-linux-gnu
+.endif

Created attachment 257076 [details]
[PATCH] net/boinc-client: configure alternate platform according to ${ARCH}

(In reply to Vladimir Druzenko from comment #9)

Thank you for the idea: I improved it even more :)

Comment 11 Vladimir Druzenko 2025-01-29 16:40:52 UTC

Options in the port is "very broken" - fixing and testing are in progress…

Comment 12 Vladimir Druzenko 2025-01-29 22:13:51 UTC

Created attachment 257103 [details]
v1

Improve port:
- fix options - dependencies, plist, configure options;
- fix check for symlinks in pkg-deinstall;
- fix warnings from portclippy;
- configure alternate platform according to ${ARCH} for option LINUX.

Can you test this patch?

Comment 13 commit-hook 2025-01-31 23:03:58 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=209307e6d5bc4b3a48a5e7d7447378f2fa786aec

commit 209307e6d5bc4b3a48a5e7d7447378f2fa786aec
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-01-31 22:56:46 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-31 23:02:45 +0000

    net/boinc-client: configure alternate platform according to ${ARCH}, fix options

    Improve port:
    - fix options - dependencies, plist, configure options;
    - fix check for symlinks in pkg-deinstall;
    - fix warnings from portclippy;
    - configure alternate platform according to ${ARCH} for option LINUX
    (patch from Älven <alster@vinterdalen.se>).

    PR:             272727
    Approved by:    ler (maintainer, timeout > 7 months)

 net/boinc-client/Makefile               | 58 ++++++++++++++++++---------------
 net/boinc-client/files/pkg-deinstall.in | 12 ++++---
 net/boinc-client/pkg-plist              |  6 ++--
 3 files changed, 43 insertions(+), 33 deletions(-)

Comment 14 Vladimir Druzenko 2025-01-31 23:05:46 UTC

Thanks.

Created attachment 257157 [details]
[PATCH] [FOLLOW-UP] net/boinc-client: improve port

(In reply to Vladimir Druzenko from comment #14)

Thank you too. Sorry for being too late: you was so fast to commit it :)
I've just successfully tested it on my local BOINC instance, all works well.

And just this small follow-up, please, removing unnecessary dos2unix and tar from USES.

Comment 17 Vladimir Druzenko 2025-01-31 23:37:23 UTC

(In reply to Älven from comment #16)
> removing unnecessary dos2unix
Why unnecessary?
I see:
DOS2UNIX_GLOB=  *.xpm

Yes, it is written, but no actual XPM files do have DOS-encoding in current versions of BOINC. It may be actual some time in the past. You may check it yourself, if you like or just need to.

Comment 19 Vladimir Druzenko 2025-01-31 23:41:30 UTC

All files *.xpm already have UNIX "End Of Lines"?

Comment 20 Vladimir Druzenko 2025-01-31 23:45:44 UTC

(In reply to Älven from comment #16)
Something else? Before I commit this change. :-)

(In reply to Vladimir Druzenko from comment #20)
> Something else? Before I commit this change. :-)

Thank you. Looks like you are kind and not angry on me :-)
Nothing I could remember for now.

P.S. I've run 
% find . -not -type d -exec file "{}" ";" | grep CRLF
on extracted tarball of the port, and no XPM file was found.
Some files which still did were lot of *.vcxproj XMLs from "win_build" folder and alike and some *.bat files. None of this seems to be relevant to non-windows builds, I think.

P.P.S. I really opened several (not all) of these XPMs with my GNU/EMACS.
Mode line clearly showed common "-UU-:@---", so UNIX. For *.bat files it showed
"-UU-(DOS)@---".