Bug 272773

Summary: net/ntp: missing homepage in pkg-descr
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Not A Bug    
Severity: Affects Only Me CC: cy
Priority: --- Flags: bugzilla: maintainer-feedback? (cy)
Version: Latest   
Hardware: Any   
OS: Any   

Description Mikael Urankar freebsd_committer freebsd_triage 2023-07-28 11:40:39 UTC 
pkg-descr lacks the homepage:

tail -n 1 pkg-descr 
See homepage for more infos:

It was removed in https://cgit.freebsd.org/ports/commit/?id=fb16dfecae4a6efac9f3a78e0b759fb7a3c53de4
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2023-07-28 15:13:22 UTC 
It's supposed to be that way.

Can we mark this PR as a troll and SPAM, please.
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2023-07-28 15:48:24 UTC 
Troll? Are you serious?
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2023-07-28 16:09:31 UTC 
Yes. WWW was removed from all pkg-descr from all ports and moved to Makefile around the time that b7f05445c00f2 was committed. This is common knowledge.
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2023-07-28 16:12:46 UTC 
Also, look at every other port in the tree. Don't just pick on net/ntp. Open up a discussion on freebsd-ports@. And, if you truly believe this is a problem, you are free to assign this PR to portmgr@ because this is also true for every other port in the tree.
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2023-07-28 16:13:32 UTC 
(In reply to Mikael Urankar from comment #2)
Given all this information discussed above, you can see why I thought this was a troll.
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2023-07-28 16:29:21 UTC 
In french a sentence never ends with a semicolon. Esther remove the last line in pkg-descr or put a link to the home page.
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2023-07-28 16:42:13 UTC 
(In reply to Mikael Urankar from comment #6)

That's a fair assessment. True in English as well.
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-07-28 16:52:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e6699a2ba75b6060c3b93090959d6f458f1865b

commit 3e6699a2ba75b6060c3b93090959d6f458f1865b
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-07-28 16:44:13 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-07-28 16:51:08 +0000

    net/ntp: Remove extraneous sentence suggesting a WWW

    fb16dfecae4a removed WWW lines without considering the context.
    Remove the sentence that eludes to a WWW line that no longer exists.

    PR:             272773
    Fixes:          fb16dfecae4a
    MFH:            2023Q3

 net/ntp/Makefile  | 1 +
 net/ntp/pkg-descr | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-07-28 22:27:00 UTC 
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48721c20fd4a341727b412c58e56dd25d99f7997

commit 48721c20fd4a341727b412c58e56dd25d99f7997
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-07-28 16:44:13 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-07-28 22:26:27 +0000

    net/ntp: Remove extraneous sentence suggesting a WWW

    fb16dfecae4a removed WWW lines without considering the context.
    Remove the sentence that eludes to a WWW line that no longer exists.

    PR:             272773
    Fixes:          fb16dfecae4a

    (cherry picked from commit 3e6699a2ba75b6060c3b93090959d6f458f1865b)

 net/ntp/Makefile  | 1 +
 net/ntp/pkg-descr | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)