Bug 272831
| Summary: | x11/polybar: Add patches for CPU and memory module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Joel Bodenmann <jbo> | ||||
| Component: | Individual Port(s) | Assignee: | Alexandre C. Guimarães <rigoletto> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(rigoletto) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hi. I will try to commit it during the weekend. Also, I'm with severe time issues and not using polybar anymore (what make harder to test). Would you like to take the maintainership? Thank you. Hi, Yeah I can take over maintainership - no problem! Would you like to handle this PR before transferring maintainership or shall we transfer immediately? Thank you for your maintenance efforts so far! :) Could you please re-create the patch against the lastest HEAD, it is failing to apply in here? I change the maintainer when committing your patches. Thank you. Can you provide some information regarding "it is failing to apply in here?". I can apply it successfully to the current HEAD. Your comment made me doubt tho so I re-created the patch again (good exercise) and it's still applying just like before. I am seeing trailing-whitespace warnings but I have no idea where they originate from. The upstream patches contained within the current version of the port patch have been created using `git diff --no-index`. The second time I created the port I used `make makepatch` and they both result in the same whitespace warnings when being applied. Nevertheless, it applies correctly as far as I can tell. (In reply to Joel Bodenmann from comment #4) Those were at lines 28, 36, 41, 80, 104, 109, and 132. I fixed them in here now. ;-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6cdddcb8fd5df5db70abb86c4abe56664b60c7f9 commit 6cdddcb8fd5df5db70abb86c4abe56664b60c7f9 Author: Joel Bodenmann <jbo@insane.engineer> AuthorDate: 2023-08-06 03:04:55 +0000 Commit: Alexandre C. Guimarães <rigoletto@FreeBSD.org> CommitDate: 2023-08-06 03:04:55 +0000 x11/polybar: Add patches for CPU and memory modules - give it to Joel Bodenmann <jbo@insane.engineer> PR: 272831 x11/polybar/Makefile | 4 +- x11/polybar/files/patch-src_modules_cpu.cpp (new) | 66 ++++++++++++++++++++++ .../files/patch-src_modules_memory.cpp (new) | 49 ++++++++++++++++ x11/polybar/pkg-message | 4 +- 4 files changed, 119 insertions(+), 4 deletions(-) Thank you. |
Created attachment 243720 [details] patch I've added patches to make the CPU & memory module work under FreeBSD. Patches have been handed to upstream but it's questionable when and whether they will be accepted given that upstream is pretty Linux centric.