Bug 273042

Summary: x11-wm/hikari: drop setuid bit from hikari-unlocker
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: ashish
Priority: --- Flags: ashish: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 (apply via "git am") none

Description Jan Beich freebsd_committer freebsd_triage 2023-08-10 09:37:54 UTC
Created attachment 244001 [details]
v1 (apply via "git am")

Similar to ports 1a6e018f6243 + ports 4f53b9995818.

Disclaimer: Runtime is untested as I don't use Hikari.
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2023-08-11 12:43:12 UTC
Unfortunately, I could not test this either, as my FreeBSD desktop is not in a working state, and won't be for few months.

So, if you think it's okay, then feel free to commit.

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-11 13:43:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=592d2bec114d2ae04e564c22b6a175773c28ab40

commit 592d2bec114d2ae04e564c22b6a175773c28ab40
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-10 09:31:47 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-11 13:41:28 +0000

    x11-wm/hikari: drop setuid bit from hikari-unlocker

    PR:             273042
    Approved by:    ashish (maintainer)

 x11-wm/hikari/Makefile                                            | 3 ++-
 x11-wm/hikari/files/patch-etc_pam.d_hikari-unlocker.FreeBSD (new) | 8 ++++++++
 x11-wm/hikari/pkg-plist                                           | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-08-11 13:44:06 UTC
Tested myself: locking and unlocking works fine.