Bug 273044

Summary: sysutils/libdnf: fix regex and duplicate rtti
Product: Ports & Packages Reporter: Brad Davis <brd>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: markj
Priority: --- Flags: bugzilla: maintainer-feedback? (yuri)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
duplicate rtti patch
none
use POSIX regex
none
ports patch, use POSIX regex
none
ports patch, avoid duplicating RTTI none

Description Brad Davis freebsd_committer freebsd_triage 2023-08-10 13:29:11 UTC
Created attachment 244002 [details]
duplicate rtti patch
Comment 1 Brad Davis freebsd_committer freebsd_triage 2023-08-10 13:29:38 UTC
Created attachment 244004 [details]
use POSIX regex
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-10 23:05:20 UTC
Hi Brad,

I think these patches should be submitted as pull request(s) for the libdnf project, unless they are FreeBSD-specific. But I don't see how are they FreeBSD-specific.

Yuri
Comment 3 Brad Davis freebsd_committer freebsd_triage 2023-08-14 17:13:34 UTC
Yes, I will work on getting these upstream, but we would like to get them in the ports tree sooner than later since we do not know when they will do a new release.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-14 17:47:39 UTC
(In reply to Brad Davis from comment #3)

Hi Brad,

The patches don't apply to the port version 0.70.2
Are they for the master branch?

Could you please add the patch for the port?


Thanks,
Yuri
Comment 5 Mark Johnston freebsd_committer freebsd_triage 2023-08-24 21:55:36 UTC
Created attachment 244318 [details]
ports patch, use POSIX regex

A patch against the ports tree.  Upstream PR submitted: https://github.com/rpm-software-management/libdnf/pull/1617
Comment 6 Mark Johnston freebsd_committer freebsd_triage 2023-08-24 21:56:17 UTC
Created attachment 244319 [details]
ports patch, avoid duplicating RTTI

Here's a patch against the ports tree.  Submitted upstream here: https://github.com/rpm-software-management/libdnf/pull/1618
Comment 7 Mark Johnston freebsd_committer freebsd_triage 2023-08-24 21:58:10 UTC
(In reply to Yuri Victorovich from comment #4)
I attached patches against the ports tree itself, and submitted upstream PRs.  I have no idea how likely they are to be accepted, but without them the sysutils/dnf port is rather useless:

markj@nuc> dnf --version
Abort trap (core dumped)
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-25 03:01:16 UTC
Committed, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-08-25 03:01:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=49b7f1c6cb2e742931b85e49d532b8993c4eeb61

commit 49b7f1c6cb2e742931b85e49d532b8993c4eeb61
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-08-25 02:58:46 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-25 03:01:10 +0000

    sysutils/libdnf: Fix regex and duplicate rtti

    PR:             273044

 sysutils/libdnf/Makefile                            |  1 +
 .../patch-bindings_python_____init____.py (new)     | 21 +++++++++++++++++++++
 .../patch-libdnf_repo_DependencySplitter.cpp (new)  | 14 ++++++++++++++
 3 files changed, 36 insertions(+)