Bug 273137
| Summary: | emulators/wine: Fix untracked dependency of alsa-plugins and 32-Bit pkg messages for wine7 and wine-devel | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alexander Vereeken <Alexander88207> |
| Component: | Individual Port(s) | Assignee: | Gerald Pfeifer <gerald> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | Flags: | gerald:
maintainer-feedback+
|
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 244099 [details]
Fix untracked dependency of alsa-plugins and 32-Bit pkg messages for wine7 and wine-devel (V2)
Fix typo
Thank you, Alexander! Just to confirm, alsa-plugins is purely a run time dependency, not required at build time? It may take a few days, but I'll see to commit your changes to the (now) three wine* ports! Yes, the port alsa-plugins is not required for building. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=16d8a4b821d2db0134901589e22740290cc40020 commit 16d8a4b821d2db0134901589e22740290cc40020 Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2023-08-15 21:57:36 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-15 21:57:36 +0000 emulators/wine-devel: Fix 32-bit pkg invocation for WoW64 This addresses a regression introduced with commit 3f914243d8179e0d on 2022-03-12 which was a forward port from emulators/wine and not sufficiently adjusted to this port). Do not bump PORTREVISION since 32-bit builds are broken right now. PR: 273137 emulators/wine-devel/files/wine-wow64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a26844393bb20a18203cc5c218d593244c7ab577 commit a26844393bb20a18203cc5c218d593244c7ab577 Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2023-08-16 11:17:32 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-16 11:17:32 +0000 emulators/wine: Add dependency on alsa-plugins When using the ALSA option (which is not the default) audio did not worke - no audio device appeared for playing and recording and the following message appeared: ALSA lib dlmisc.c:285:(snd_dlobj_cache_get0) Cannot open shared library /usr/local/lib/alsa-lib/libasound_module_pcm_oss.so Providing alsa-plugins at run time addresses this. Bump PORTREVSION accordingly. PR: 273137 emulators/wine/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) We have to change from ALSA_RUN_DEPENDS= libasound_module_pcm_oss.so:audio/alsa-plugins to ALSA_RUN_DEPENDS= alsa-plugins>0:audio/alsa-plugins I forgot that when using RUN_DEPENDS it will look for executables but not for libs that do only gets used for running. Sorry for that... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8cd3e4f0fc7a696019bd3cbeaa810679f23d1482 commit 8cd3e4f0fc7a696019bd3cbeaa810679f23d1482 Author: Gerald Pfeifer <gerald@FreeBSD.org> AuthorDate: 2023-08-16 11:41:53 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-17 21:08:39 +0000 emulators/wine7: Adjust 32-bit pkg invocation for WoW64 When cloning wine7 from emulators/wine we missed to update the wine-wow64.sh script with the new package name. PR: 273137 emulators/wine7/files/wine-wow64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3a2594ed6fc746dd3c5518c709d0d36e03b84bcd commit 3a2594ed6fc746dd3c5518c709d0d36e03b84bcd Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2023-08-18 21:57:12 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-18 21:57:12 +0000 emulators/wine: Fix ALSA run-time dependency The form libfoo.so:category/port only works for LIB_DEPENDS; for RUN_DEPENDS we need to depend on the port as such. This fixes up commit a26844393b. Bump PORTREVSION. PR: 273137 emulators/wine/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7044c9d91429af6b9f074cb577ebc500e5349cbb commit 7044c9d91429af6b9f074cb577ebc500e5349cbb Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2023-08-19 11:19:32 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-19 11:19:32 +0000 emulators/wine7: Add run-time dependency on alsa-plugins When using the ALSA option (which is not the default) audio did not work - no audio device appeared for playing and recording and the following message appeared: ALSA lib dlmisc.c:285:(snd_dlobj_cache_get0) Cannot open shared library /usr/local/lib/alsa-lib/libasound_module_pcm_oss.so Providing alsa-plugins at run time addresses this. (This is a backport of a26844393b and 3a2594ed6f from the primary wine port.) Bump PORTREVSION accordingly. PR: 273137 emulators/wine7/Makefile | 2 ++ 1 file changed, 2 insertions(+) Hi Alexander, as far as I can tell all the changes you submitted are now in, is that correct? If so, I am planning to make a similar change re ALSA to wine-devel and then close this PR. Any other thoughts/suggestions? A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ba0e1a78f3e1623b5bc1740b2afbc1d2075c4699 commit ba0e1a78f3e1623b5bc1740b2afbc1d2075c4699 Author: Gerald Pfeifer <gerald@FreeBSD.org> AuthorDate: 2023-08-20 08:07:09 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2023-08-20 08:07:09 +0000 emulators/wine-devel: Add run-time dependency on alsa-plugins When using the ALSA option (which is not the default) audio did not work - no audio device appeared for playing and recording and the following message appeared: ALSA lib dlmisc.c:285:(snd_dlobj_cache_get0) Cannot open shared library /usr/local/lib/alsa-lib/libasound_module_pcm_oss.so Providing alsa-plugins at run time addresses this. (This is a forward port of a26844393b and 3a2594ed6f from the primary wine port.) Bump PORTREVSION accordingly. PR: 273137 emulators/wine-devel/Makefile | 2 ++ 1 file changed, 2 insertions(+) Voila! Please advise if this is alright or I missed anything. All good, thanks for taking the time Gerald. |
Created attachment 244098 [details] Fix untracked dependency of alsa-plugins and 32-Bit pkg messages for wine7 and wine-devel Hello Gerald, sry if there are a few changes in one. 1. Fix untracked dependency of alsa-plugins. When using the alsa option the audio didn't worked for me until alsa-plugins got installed. If the package alsa-plugins is not installed then no audio device will appear for Play and Rec and you will get the message below: ALSA lib dlmisc.c:285:(snd_dlobj_cache_get0) Cannot open shared library /usr/local/lib/alsa-lib/libasound_module_pcm_oss.so ((null): Cannot open "/usr/local/lib/alsa-lib/libasound_module_pcm_oss.so" I do only have applied the fix it for wine and wine7 so far, didnt tested it in for wine-devel (but the same case i guess) 2. Fix 32-Bit pkg messages for wine7 and wine-devel