Bug 273240
| Summary: | biology/star: Drop hardcoded avx2 argument | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Jason W. Bacon <jwb> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | diizzy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(jwb) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
The build info is also borked (git hash is incorrect for example) Comment out BUILD_DATE, BUILD_PLACE and GIT_BRANCH_COMMIT_DIFF and define something sane instead. See https://cgit.freebsd.org/ports/tree/net/libwebsockets/Makefile#n18 for example A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0e8f22496e314bf6c0f863722217eb8bebef9cf2 commit 0e8f22496e314bf6c0f863722217eb8bebef9cf2 Author: Jason W. Bacon <jwb@FreeBSD.org> AuthorDate: 2023-08-21 14:33:20 +0000 Commit: Jason W. Bacon <jwb@FreeBSD.org> CommitDate: 2023-08-21 14:33:20 +0000 biology/star: Fix SIMD issue on non-amd64 Also remove some extraneous build flags from upstream Makefile PR: 273240 Reported by: dizzy biology/star/Makefile | 9 ++------- biology/star/files/patch-Makefile | 12 +++++++----- 2 files changed, 9 insertions(+), 12 deletions(-) (In reply to Daniel Engberg from comment #0) ALL platforms? The port was poudriere-tested on amd64 12.4 and 13.2. I normally test on aarch64 as well, but apparently it slipped my mind this time. Thanks for the heads-up. (In reply to Daniel Engberg from comment #1) Borked it may be, but the date/time format needs to match what upstream provides, since users might be parsing the output in order to document methods in their publications. I'm not concerned about the git has as it is not included in the output. Binary provided by upstream: # ./STAR-linux STAR version=2.7.11a STAR compilation time,server,dir=2023-08-15T11:38:34-04:00 :/home/dobin/data/STAR/STARcode/STAR.master/source FreeBSD port: # STAR STAR version=2.7.11a STAR compilation time,server,dir=2023-08-21T09:30:32-05:00 :/usr/ports/biology/star/work/STAR-2.7.11a/source (In reply to Jason W. Bacon from comment #3) Since it builds I'm going to assume it also runs which means it'll likely break on any platform that don't support avx instructions on AMD64. Thanks for looking into the git stuff (In reply to Daniel Engberg from comment #5) Seems to work fine on my ROCK64. (In reply to Jason W. Bacon from comment #6) As expected :-) Commmit 0e8f22496e314bf6c0f863722217eb8bebef9cf2 fixed it on all platforms including AMD64, in case I wasn't clear "all platforms" was valid before this commit landed. |
Created attachment 244221 [details] Patch for star This breaks on all platforms, rely on CPUTYPE from the framework instead