Bug 273244

Summary: FDP: make the FreeBSD Documentation Project Primer realistic, with regard to contributions
Product: Documentation Reporter: Graham Perrin <grahamperrin>
Component: Books & ArticlesAssignee: Sergio Carlavilla Delgado <carlavilla>
Status: Closed Not Accepted    
Severity: Affects Many People CC: carlavilla, doc, doceng, imp
Priority: --- Keywords: easy, needs-patch
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/freebsd/freebsd-doc/commit/c4ab126805b0ecf8d200daba8990ddaac649b18f#diff-d1c4411873fcc149d78fd656312ffd32333c80fbfc328cc1909adfc0217a686fR101
See Also: https://reviews.freebsd.org/D41601
https://gitlab.com/gitlab-org/gitlab/-/issues/19114
Attachments:
Description Flags
notification buttons – None | All | Status
none
Edit this page
none
signed-off .patch grahamperrin: maintainer-approval? (doceng)

Description Graham Perrin 2023-08-20 12:33:26 UTC 
Created attachment 244225 [details]
notification buttons – None | All | Status

> Edit this page

- appears in documentation at docs.freebsd.org – for example, 
  <https://docs.freebsd.org/en/books/fdp-primer/overview/>

> … we value your contributions very highly. …

The resulting workflow (three buttons, a norm for users of GitHub): 

1. Commit changes…

2. Propose changes

3. Create pull request

Where people oversubscribe – and then, are either unaware (or wilfully ignorant) of None and Status buttons: 

- contributions may be perceptibly less than valuable. 

Please fix the primer. 

At least: be honest about what contributors should expect.

Thanks

----

In the meantime, there remain seven PRs at <https://github.com/freebsd/freebsd-doc/pulls>: 

- some of which might please subscribers, in the context of  
  <https://docs.freebsd.org/en/books/fdp-primer/book/#weblate-become-translator> 
  point 6

    "… The Documentation project is also accepting GitHub 
     Pull Requests with translation submissions."

- others might cause displeasure, and be subject to moves 
  away from the FreeBSD repo, to forks.
Comment 1 Graham Perrin 2023-08-20 15:53:23 UTC 
Created attachment 244228 [details]
Edit this page

A screenshot of the button.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2023-08-22 02:40:30 UTC 
imp, is this something that you have an opinion on w/rt the git efforts?
Comment 3 Graham Perrin 2023-08-31 16:00:52 UTC 
<https://github.com/freebsd/freebsd-doc/commit/e52c79320b03645cf9097d883e9d3aae2177ca60>

> Documentation Portal: Move GitHub url from edit to blob · …
Comment 4 Graham Perrin 2023-09-01 01:26:54 UTC 
Created attachment 244539 [details]
signed-off .patch

e52c79320b03 Documentation Portal: Move GitHub url from edit to blob

The invitation to 'Edit this page' no longer results in edit mode.

Make the invitation consistent with the effect of clicking.
Comment 5 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2023-10-01 09:52:24 UTC 
We changed the title of the action, we think is ok as it right now.
Comment 6 Graham Perrin 2023-10-01 10:28:00 UTC 
(In reply to Graham Perrin from comment #4)

Attention, please, to the patch, for which approval was requested.