Bug 273299
| Summary: | graphics/povray37: Clean up Makefile | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Philipp Ost <bsd> | ||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | diizzy, fernape | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273098 | ||||||
| Attachments: |
|
||||||
Thanks for the patch Philipp, I bumped PORTREVISION too due to the change in options. Also, it seems that the COMPILED_BY changed meaning from "who built this" to "what platform this software was built in"? Cheers. (In reply to Fernando Apesteguía from comment #1) Yes. Whoever took care of the POV-Ray ports before me settled on "who built this". I think it's just as fine to change this to "what platform was this built on" as This should still fulfill POV-Ray's requirement that binaries from other sources than the official project be indicated as such. See https://github.com/POV-Ray/povray/blob/76a804d18a30a1dbb0afbc0070b62526715571eb/unix/install.txt#L43 for the official wording. Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cbf6cea662f53deb0477cfd5f52b3dffb4cd2de5 commit cbf6cea662f53deb0477cfd5f52b3dffb4cd2de5 Author: Philipp Ost <bsd@philippost.de> AuthorDate: 2023-08-23 06:36:42 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-08-25 06:49:45 +0000 graphics/povray37: Clean up Makefile - set COMPILED_BY variable as proposed by diizzy@ - drop the STATIC option - make use of ports framework for options PNG, JPEG, TIFF, OPENEXR PR: 273299 Reported by: bsd@philippost.de (maintainer) graphics/povray37/Makefile | 72 ++++++++++++---------------------------------- 1 file changed, 18 insertions(+), 54 deletions(-) |
Created attachment 244290 [details] graphics/povray37/Makefile: Clean up Makefile Clean up the Makefile to keep in sync with graphics/povray36 and graphics/povray38: - set COMPILED_BY variable as proposed by diizzy@ - drop the STATIC option - make use of ports framework for options PNG, JPEG, TIFF, OPENEXR