Bug 273310
| Summary: | www/ungoogled-chromium: undefined MFD_CLOEXEC targeting 12.4 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John F. Carr <jfc> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-chromium (Nobody) <chromium> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dch, rnagy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(chromium) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 244309 [details]
patch-ui_ozone_platform_wayland_host_zwp__text__input__wrapper__v1.cc
(In reply to John F. Carr from comment #0) Hi Could you please try the attached patch? (In reply to Robert Nagy from comment #2) The added PLOG(ERROR) line needs a semicolon at the end. With that change the port builds targeting 12.4. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ffba5c0cb30d6daf257013be5293a41db703589c commit ffba5c0cb30d6daf257013be5293a41db703589c Author: Robert Nagy <rnagy@FreeBSD.org> AuthorDate: 2023-08-24 14:52:10 +0000 Commit: Robert Nagy <rnagy@FreeBSD.org> CommitDate: 2023-08-24 14:53:05 +0000 www/*chromium: unbreak build on 12.4; no MFD_CLOEXEC support PR: 273310 ...land_host_zwp__text__input__wrapper__v1.cc (new) | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) A commit in branch 2023Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7a9feac1998a9d86166a1b80c3ff386922e6f6b5 commit 7a9feac1998a9d86166a1b80c3ff386922e6f6b5 Author: Robert Nagy <rnagy@FreeBSD.org> AuthorDate: 2023-08-24 14:52:10 +0000 Commit: Robert Nagy <rnagy@FreeBSD.org> CommitDate: 2023-08-24 14:53:59 +0000 www/*chromium: unbreak build on 12.4; no MFD_CLOEXEC support PR: 273310 (cherry picked from commit ffba5c0cb30d6daf257013be5293a41db703589c) ...land_host_zwp__text__input__wrapper__v1.cc (new) | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) AFAICT supplied patch has addressed this, please re-open if not. |
I am building for an amd64 12.4 target using poudriere on a 13.2 host. Building ungoogled-chromium fails with an undefined variable MFD_CLOEXEC. The memfd_create(MFD_CLOEXEC) interface does not exist in FreeBSD 12. ../../ui/ozone/platform/wayland/host/zwp_text_input_wrapper_v1.cc:227:59: error: use of undeclared identifier 'MFD_CLOEXEC' base::ScopedFD memfd(memfd_create("surrounding_text", MFD_CLOEXEC)); ^ The package version is 116.0.5845.96.