Bug 273345

Summary: net-im/jitsi-videobridge build fails - depends on mvn
Product: Ports & Packages Reporter: Marko Cupać <marko.cupac>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me CC: cryx-ports, john, m.ne
Priority: --- Flags: bugzilla: maintainer-feedback? (acm)
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
Fix picking up maven dependency m.ne: maintainer-approval?

Description Marko Cupać 2023-08-25 12:38:51 UTC 
Hi,

I can't seem to build jitsi-videobridge anymore:

===>   jitsi-videobridge-2.2.79 depends on file: /usr/local/share/java/maven/bin/mvn - not found
*** Error code 1

This is on 13.2 amd64, both host and poudriere jail.
Comment 1 Philipp Wuensche 2023-08-30 07:13:05 UTC 
Same here,

from the poudriere logfile:

===>   jitsi-videobridge-2.2.79 depends on file: /usr/local/share/java/maven/bin/mvn - not found
===>   Installing existing package /packages/All/maven-3.8.8_1.pkg

and later:

===>   jitsi-videobridge-2.2.79 depends on file: /usr/local/share/java/maven/bin/mvn - not found
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/jitsi-videobridge

If we look into the maven-3.8.8_1.pkg we can see:

% tar tzfv maven-3.8.8_1.pkg | grep bin/mvn
-r-xr-xr-x  0 root   wheel    5368 Aug 30 03:01 /usr/local/share/java/apache-maven-3.8/bin/mvn

So this could be the source of the problem, the mvn binary is at a different location then expeceted.

An indeed, there was a PR (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272899) which included this patch https://cgit.freebsd.org/ports/commit/?id=a1c897de331a3363f0d74b0decf8d07ae2498f1c 
Reversing the patch on my ports tree, bringing maven back from 3.8.8_1 to 3.8.8, made everything work again.
Comment 2 Martin Neubauer 2023-09-02 11:54:37 UTC 
Created attachment 244584 [details]
Fix picking up maven dependency
Comment 3 Martin Neubauer 2023-09-02 11:58:06 UTC 
I stumbled over this as well, but rather than reverting the commit changed the dependency line to how every other port using maven does it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-09-20 06:30:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e18c06c0174b9072146590ce09881306130f96e

commit 5e18c06c0174b9072146590ce09881306130f96e
Author:     Marko Cupać <marko.cupac@mimar.rs>
AuthorDate: 2023-09-20 06:29:18 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2023-09-20 06:30:22 +0000

    net-im/jitsi-videobridge: Fix picking up maven dependency

    PR:             273345

 net-im/jitsi-videobridge/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2023-09-20 06:32:06 UTC 
Committed thanks! (Martin, I put wrong author in my commit, sorry)