Bug 273349

Summary: www/chromium linker error
Product: Ports & Packages Reporter: Bob Prohaska <fbsd>
Component: Individual Port(s)Assignee: freebsd-chromium (Nobody) <chromium>
Status: Closed FIXED    
Severity: Affects Only Me CC: rnagy
Priority: --- Flags: bugzilla: maintainer-feedback? (chromium)
Version: Latest   
Hardware: arm64   
OS: Any   
Attachments:
Description Flags
neon.patch none

Description Bob Prohaska 2023-08-25 15:40:16 UTC 
A Pi4 running -current fails to build www/chromium using poudriere, failing
with a linker error. 

The log file is at
http://nemesis.zefox.com/~bob/data/logs/bulk/main-default/2023-08-20_16h11m59s/logs/errors/chromium-115.0.5790.170_1.log
Comment 1 Robert Nagy freebsd_committer freebsd_triage 2023-08-27 15:50:53 UTC 
Created attachment 244390 [details]
neon.patch

Hi

Could you please give the attached patch a try?

Thanks
Comment 2 Bob Prohaska 2023-08-27 17:22:13 UTC 
The Pi4 in question is building ungoogled-chromium at the moment,
which will take a few days to either finish or fail. I'll try to 
stop the build if it's headed for failure, but quickly and cleanly
stopping poudriere has so far eluded me. 

In the meantime, what's the best way to download the patch? I don't
presently have a working browser on the Pi4, so I'll have to download
to another host and sftp it to the Pi4. I don't see any download option
within the page for bug 273349. Copy and paste seemed unreliable in the
past.
Comment 3 Robert Nagy freebsd_committer freebsd_triage 2023-08-27 17:26:10 UTC 
(In reply to Bob Prohaska from comment #2)

You can stop that build as well because you will run into the same issue.
I will get this fixed and committed soon, because I've found the root cause.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-27 18:00:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=919638f2014d06b489db252c378714fbac038f83

commit 919638f2014d06b489db252c378714fbac038f83
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-08-27 17:57:35 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-08-27 17:59:55 +0000

    www/{*chromium,iridium}: unbreak arm64 relocation in bundled ffmpeg

    enable support for the .data.rel.ro section because the arm64
    assembly code in ffmpeg depends on it

    PR:     273349

 www/chromium/files/patch-third__party_ffmpeg_configure (new)   | 10 ++++++++++
 www/iridium/files/patch-third__party_ffmpeg_configure (new)    | 10 ++++++++++
 .../files/patch-third__party_ffmpeg_configure (new)            | 10 ++++++++++
 3 files changed, 30 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-08-27 18:01:20 UTC 
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0721986dfe0327297b6eee68e732373684de9921

commit 0721986dfe0327297b6eee68e732373684de9921
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-08-27 17:57:35 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-08-27 18:00:54 +0000

    www/{*chromium,iridium}: unbreak arm64 relocation in bundled ffmpeg

    enable support for the .data.rel.ro section because the arm64
    assembly code in ffmpeg depends on it

    PR:     273349
    (cherry picked from commit 919638f2014d06b489db252c378714fbac038f83)

 www/chromium/files/patch-third__party_ffmpeg_configure (new)   | 10 ++++++++++
 www/iridium/files/patch-third__party_ffmpeg_configure (new)    | 10 ++++++++++
 .../files/patch-third__party_ffmpeg_configure (new)            | 10 ++++++++++
 3 files changed, 30 insertions(+)