Bug 273367
| Summary: | sysutils/walk: Update to 1.6.2, Rename from sysutils/llama to sysutils/walk | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jesús Daniel Colmenares Oviedo <DtxdF> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | fernape, vsasjason | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://github.com/antonmedv/walk/releases/tag/v1.6.2 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jesús Daniel Colmenares Oviedo
2023-08-26 17:15:34 UTC
Created attachment 244397 [details]
walk-1.5.2.patch
* Add an entry to MOVED.
Created attachment 244449 [details]
walk-1.6.2.patch
Description:
* Update to 1.6.2.
QA:
* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.2-RELEASE, amd64)
Hi Jesús, I don't think the patch is right. It removed llama/Makefile and llama/distinfo but leaves llama/pkg-descr there. In addition that file is changed to mention walk instead of llama :S Could you please have a look? Thanks! (In reply to Fernando Apesteguía from comment #3) Hi Fernando, I agree with you, this patch is not correct. I have tried to update and rename but I think it might be better to use this bug to simply rename the port and create another one to update it. Give me a moment and I will send you another patch. Thanks! Created attachment 244466 [details]
walk-1.6.2.patch
Description:
* Change pkg-descr to mention llama instead of walk.
* Update MOVED (conflict with the new MOVED as it was recently upgraded.).
QA:
* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.2-RELEASE, amd64)
* Tools/scripts/MOVEDlint.awk: OK
(In reply to Fernando Apesteguía from comment #3) > It removed llama/Makefile and llama/distinfo but leaves llama/pkg-descr there. I have checked and this is for git's similarity index feature as the content is not changed. > In addition that file is changed to mention walk instead of llama :S Thanks for this, I thought pkg-descr should be changed when a port name is changed. I have checked some other ports that were updated recently and they do not change such a thing. --- Thanks! (In reply to Jesús Daniel Colmenares Oviedo from comment #6) Thanks for the update. I had to manually edit MOVED since the patch did not apply anymore. Also I needed to add the new sysutils/walk to sysutils/Makefile to hook it to the tree. Build testing in progress... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c6a227c105d07a4db3d21a7947098aaf60261f23 commit c6a227c105d07a4db3d21a7947098aaf60261f23 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-08-30 13:19:13 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-08-31 09:47:16 +0000 sysutils/walk: Update to 1.6.2 and rename ChangeLog: https://github.com/antonmedv/walk/releases/tag/v1.6.2 "llama" became "walk" upstream. PR: 273367 Reported by: DtxdF@disroot.org (maintainer) MOVED | 1 + sysutils/Makefile | 1 + sysutils/llama/Makefile (gone) | 39 ---------------------------------- sysutils/llama/distinfo (gone) | 39 ---------------------------------- sysutils/walk/Makefile (new) | 42 +++++++++++++++++++++++++++++++++++++ sysutils/walk/distinfo (new) | 43 ++++++++++++++++++++++++++++++++++++++ sysutils/{llama => walk}/pkg-descr | 2 +- 7 files changed, 88 insertions(+), 79 deletions(-) Committed, Thanks! This should be reopened as sysutils/Makefile has been changed incorrectly — "walk" added, but no "llama" removed. (In reply to Anton Saietskii from comment #10) Thanks! Fixed. Running make describe to double check everything is right... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9ad1624f3ceb6ce358a37ace0668baf63ce70409 commit 9ad1624f3ceb6ce358a37ace0668baf63ce70409 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-08-31 12:10:43 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-08-31 12:15:12 +0000 sysutils/Makefile: Remove llama During the rename, the old port was not removed from the makefile. PR: 273367 Reported by: vsasjason@gmail.com Fixes: c6a227c105d07a4db3d21a7947098aaf60261f23 sysutils/Makefile | 1 - 1 file changed, 1 deletion(-) |
