Bug 273419

Comment 1 Fernando Apesteguía 2023-08-30 08:38:05 UTC

Hi there,

I'm confused.
The PR says update to *2.3.7* so does the attachment title, but in the diff there looks like an update to *2.3.6* instead.

-PORTVERSION=	2.3.4
+PORTVERSION=	2.3.6

OP, maintainer, could you please clarify?

Thanks!

Comment on attachment 244439 [details]
Update vagrant to 2.3.7

I was asked to use git format-patch (instead of git diff) for ports I maintain, so I used that here as well. The file contains several parts (3 to be exact; 2.3.6 update, fix to pkg-plist and 2.3.7 update). If you'd rather have a git diff patch I can create that easily as well

Comment 3 Fernando Apesteguía 2023-08-30 08:59:25 UTC

(In reply to Ralf van der Enden from comment #2)
Sorry I missed that.

The patch is perfectly fine.

Thanks!

Comment 4 Fernando Apesteguía 2023-08-31 09:02:45 UTC

(In reply to Fernando Apesteguía from comment #3)

This seems to depend on a non-existent port:

===>   vagrant-2.3.7 depends on package: rubygem-winrm-elevated>=1.2.3<2 - found
===>   Returning to build of vagrant-2.3.7
===>   vagrant-2.3.7 depends on package: rubygem-winrm-fs>=1.3.5<2 - found
===>   vagrant-2.3.7 depends on package: rubygem-winrm>=2.3.6<3 - not found
===>   Installing existing package /packages/All/rubygem-winrm-2.3.4.pkg
[13_2amd64-default] Installing rubygem-winrm-2.3.4...
the most recent version of rubygem-winrm-2.3.4 is already installed
===>   vagrant-2.3.7 depends on package: rubygem-winrm>=2.3.6<3 - not found
*** Error code 1

winrm is at 2.3.4 in the ports tree, but here it requires 2.3.6.

Can you have a look?

(In reply to Fernando Apesteguía from comment #4)

Sorry. I upgraded winrm on my local machine and forgot about that. I've added a new PR with the update to winrm 2.3.6 (see the Depends on field).

Comment 6 Fernando Apesteguía 2023-09-04 06:33:41 UTC

Committed,

Thanks!

Comment 7 commit-hook 2023-09-04 06:34:29 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=334c78087fd3eba8fe93f4ed4407c97804ed70c7

commit 334c78087fd3eba8fe93f4ed4407c97804ed70c7
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-08-30 08:58:53 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-09-04 06:33:18 +0000

    sysutils/vagrant: update to 2.3.7

    ChangeLog: https://github.com/hashicorp/vagrant/blob/v2.3.7/CHANGELOG.md

    2.3.7 (June 15, 2023)

    IMPROVEMENTS:

     * command/ssh: Enable deprecated key types and algorithms
     * core: Update user error message on failed extension installs
     * core: Support loading legacy providers in OpenSSL 3
     * provisioner/salt: Verify bootstrap-salt download

    BUG FIXES:

     * communicator/ssh: Remove keyboard-interactive auth method
     * provisioner/salt: Fix usage on Windows guests

    VAGRANT-GO:

     * Update data layer implementation
     * Update dependencies

    2.3.6 (May 19, 2023)

    BUG FIXES:

     * command/serve: Isolate proto constants to file for auto-loading
     * core/util: Unlock file prior to deletion
     * provider/docker: Attempt using docker command for bridge ip
     * provider/virtualbox: Update preferred locale values for driver

    2.3.5 (May 15, 2023)

    BUG FIXES:

     * communicator/ssh: Use netssh builtin keep alive functionality
     * communicator/ssh: Update connection settings when using a password to connect
       ssh
     * core: Add a file mutex when downloading box files
     * guest/arch: Support differentiating between Artix and Arch Linux
     * host/windows: Get state of Windows feature "Microsoft-Hyper-V-Hypervisor"
     * provider/docker: Ignore inactive docker containers when assigning ports
     * provider/docker: Sync folders before preparing nfs settings
     * provider/virtualbox: De-duplicate machine port forward info
     * provider/virtualbox: Remove check for hyperv being enabled when verifying
       virtualbox is usable on windows
     * provider/virtualbox: Validate LANG value when possible
     * provider/hyperv: Check for hyper-v feature "EnhancedSessionTransportType"
     * provisioner/ansible: Fix installing Ansible provisioner with version and pip
     * synced_folders/rsync: allow rsync-auto to also ignore relative paths

    PR:             273419
    Reported by:    tremere@cainites.net
    Approved by:    joe@thrallingpenguin.com (maintainer)

 sysutils/vagrant/Makefile  | 39 ++++++++++++++++++++++-----------------
 sysutils/vagrant/distinfo  |  6 +++---
 sysutils/vagrant/pkg-plist | 11 ++++++++---
 3 files changed, 33 insertions(+), 23 deletions(-)