Bug 273429

Summary: x11-wm/ittywm: Minor changes to COMMENT and added more to pkg-descr
Product: Ports & Packages Reporter: pyrus
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, pyrus
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Minor adjustments to COMMENT and WWW in Makefile's and added description to pkg-descr of x11-wm/ittywm and/or x11/jbxvt
none
description in ittywm
none
Adjustments to COMMENT and pkg-descr for improved wording pyrus: maintainer-approval+

Description pyrus 2023-08-30 00:46:10 UTC 
Created attachment 244451 [details]
Minor adjustments to COMMENT and WWW in Makefile's and added description to pkg-descr of x11-wm/ittywm and/or x11/jbxvt

For x11-wm/ittywm, added minor detail to COMMENT and pkg-descr in Makefile.

For x11/jbxvt updated WWW in Makefile. Old URL still works, because it redirects to current location. Added minor detail to COMMENT.

Summary of ittywm changes to Makefile and pkg-descr
-COMMENT=       Ridiculously tiny libxcb window manager
+COMMENT=       Ridiculously tiny libxcb window manager based on tinywm

-ittywm is a windowmanager in xcb which is based off of tinywm.
+ittywm is a window manager in xcb which is based off of tinywm. It is lighter on
+resources than its predecessor.


Summary of jbxvt Makefile
-COMMENT=       XVT fork in xcb
-WWW=           https://github.com/jefbed/jbxvt
+COMMENT=       XVT terminal emulator fork in libxcb
+WWW=           https://github.com/alisabedard/jbxvt

Thank you
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-30 08:24:14 UTC 
Hi there,

Thanks for the patch.
Would it be possible to have two different patches? Ideally each one should be in a separate PR.
That helps with traceability.

Can you use this PR for x11-wm/ittywm only and open a new one with the changes for x11/jbxvt?

Thanks!
Comment 2 pyrus 2023-08-30 11:38:52 UTC 
Thank you,

I'll get on it
Comment 3 pyrus 2023-08-30 12:07:53 UTC 
Created attachment 244469 [details]
description in ittywm

Added to description of x11-wm/ittywm, in COMMENT and pkg-descr.
Comment 4 pyrus 2023-08-30 13:10:59 UTC 
I'll adjust the COMMENT and pkg-descr again
Comment 5 pyrus 2023-08-30 13:28:01 UTC 
Created attachment 244473 [details]
Adjustments to COMMENT and pkg-descr for improved wording

Improvement in pkg-descr
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-30 13:33:36 UTC 
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 7 pyrus 2023-08-30 16:29:09 UTC 
Thank you. Sorry about that
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-31 09:43:03 UTC 
Committed,

Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-08-31 09:43:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=22ffecda001315777c1d74f0ee1b97d6e95d593f

commit 22ffecda001315777c1d74f0ee1b97d6e95d593f
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-08-30 13:33:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-31 09:42:26 +0000

    x11-wm/ittywm: COMMENT and pkg-descr adjustments

    PR:             273429
    Reported by:    pyrus@bsdmail.com (maintainer)

 x11-wm/ittywm/Makefile  | 2 +-
 x11-wm/ittywm/pkg-descr | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)