Bug 273534

Summary: multimedia/kodi: build fail with libressl
Product: Ports & Packages Reporter: Ivan Rozhuk <rozhuk.im>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: decke, rozhuk.im, yzrh
Priority: --- Flags: yzrh: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 273961    
Bug Blocks:    
Attachments:
Description Flags
patch
none
Use new functions for *ssl
none
testport log none

Description Ivan Rozhuk 2023-09-02 23:42:04 UTC 
[100%] Linking CXX executable kodi-x11
/usr/local/bin/cmake -E cmake_link_script CMakeFiles/kodi.dir/link.txt --verbose=1
/usr/local/libexec/ccache/c++ -O2 -pipe -O3 -pipe -funroll-loops -mretpoline -fno-delete-null-pointer-checks -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -fdebug-prefix-map=/tmp/ports/usr/ports/multimedia/kodi/work/xbmc-20.2-Nexus=. -O3 -funroll-loops -mretpoline -fno-delete-null-pointer-checks  -DLIBICONV_PLUG -Wall -Wdouble-promotion -Wmissing-field-initializers -Wsign-compare -Wextra -Wno-unused-parameter -Wno-bad-function-cast -Wno-deprecated -Wnon-virtual-dtor -O2 -pipe -O3 -pipe -funroll-loops -mretpoline -fno-delete-null-pointer-checks -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -fdebug-prefix-map=/tmp/ports/usr/ports/multimedia/kodi/work/xbmc-20.2-Nexus=. -O3 -funroll-loops -mretpoline -fno-delete-null-pointer-checks  -DLIBICONV_PLUG  -DNDEBUG  -Wl,-rpath,/usr/local/lib -fstack-protector-strong -Wl,--export-dynamic CMakeFiles/kodi.dir/xbmc/platform/posix/main.cpp.o -o kodi-x11  -Wl,-rpath,/usr/local/lib: -Wl,--whole-archive /usr/local/lib/libfstrcmp.so build/swig/libpython_binding.a build/interfaces/python/python_interface.a build/interfaces/legacy/legacy_interface.a build/rendering/gl/rendering_gl.a build/cdrip/cdrip.a build/windowing/linux/windowing_linux.a build/platform/posix/utils/platform_posix_utils.a build/platform/posix/threads/platform_posix_threads.a build/platform/posix/storage/discs/platform_posix_storage_discs.a build/platform/posix/network/platform_posix_network.a build/platform/posix/filesystem/platform_posix_filesystem.a build/platform/posix/platform_posix.a build/platform/linux/storage/platform_linux_storage.a build/platform/linux/powermanagement/platform_linux_powermanagement.a build/platform/linux/peripherals/platform_linux_peripherals.a build/platform/freebsd/network/platform_freebsd_network.a build/platform/freebsd/freebsdsupport.a build/platform/common/speech/platform_common_speech.a build/input/touch/generic/input_touch_generic.a build/input/touch/input_touch.a build/cores/VideoPlayer/videorenderers/shaders/videoshaders.a build/cores/VideoPlayer/videorenderers/hwdec/videorenderers_hwdec.a build/cores/VideoPlayer/videorenderers/videorenderers.a build/cores/VideoPlayer/process/process.a build/cores/VideoPlayer/subtitles/webvtt/subtitles_webvtt.a build/cores/VideoPlayer/subtitles/dvdsubtitles.a build/cores/VideoPlayer/inputstreams/dvdinputstreams.a build/cores/VideoPlayer/demuxers/dvddemuxers.a build/cores/VideoPlayer/codecs/video/dvdvideocodecs.a build/cores/VideoPlayer/codecs/overlay/dvdoverlaycodecs.a build/cores/VideoPlayer/codecs/audio/dvdaudiocodecs.a build/cores/VideoPlayer/codecs/dvdcodecs.a build/cores/VideoPlayer/Buffers/videoplayer-buffers.a build/cores/VideoPlayer/VideoPlayer.a build/video/windows/video_windows.a build/video/tags/video_tags.a build/video/jobs/video_jobs.a build/video/dialogs/video_dialogs.a build/video/video.a build/windows/windows.a build/windowing/windowing.a build/weather/weather.a build/view/view.a build/utils/utils.a build/threads/threads.a build/storage/storage.a build/rendering/rendering.a build/programs/programs.a build/powermanagement/powermanagement.a build/playlists/playlists.a build/platform/platform_common.a build/pictures/pictures.a build/messagingHelpers/messagingHelpers.a build/messaging/messaging.a build/listproviders/listproviders.a build/input/mouse/generic/input_mouse_generic.a build/input/mouse/input_mouse.a build/input/keyboard/generic/input_keyboard_generic.a build/input/keyboard/input_keyboard.a build/input/joysticks/keymaps/input_joystick_keymaps.a build/input/joysticks/generic/input_joystick_generic.a build/input/joysticks/dialogs/input_joystick_dialogs.a build/input/joysticks/input_joystick.a build/input/button/input_button.a build/input/actions/input_actions.a build/input/input.a build/guilib_guiinfo/guilib_guiinfo.a build/guilib/guilib.a build/favourites/favourites.a build/dialogs/dialogs.a build/dbwrappers/dbwrappers.a build/commons/commons.a build/application/application.a build/addons_settings/addons_settings.a build/addons_interfaces_gui_dialogs/addons_interfaces_gui_dialogs.a build/addons_interfaces_gui_controls/addons_interfaces_gui_controls.a build/addons_interfaces_gui/addons_interfaces_gui.a build/addons_interfaces/addons_interfaces.a build/addons_gui_skin/addons_gui_skin.a build/addons_gui/addons_gui.a build/addons_binary-addons/addons_binary-addons.a build/addons_addoninfo/addons_addoninfo.a build/addons/addons.a build/xbmc/xbmc.a build/settings/windows/settings_windows.a build/settings/lib/settings_lib.a build/settings/dialogs/settings_dialogs.a build/settings/settings.a build/cores/RetroPlayer/streams/memory/retroplayer_memory.a build/cores/RetroPlayer/streams/retroplayer_streams.a build/cores/RetroPlayer/savestates/retroplayer_savestates.a build/cores/RetroPlayer/rendering/VideoRenderers/rp-videorenderers.a build/cores/RetroPlayer/rendering/rp-rendering.a build/cores/RetroPlayer/process/rp-process.a build/cores/RetroPlayer/playback/retroplayer_playback.a build/cores/RetroPlayer/guiwindows/retroplayer_guiwindows.a build/cores/RetroPlayer/guiplayback/retroplayer_guiplayback.a build/cores/RetroPlayer/guicontrols/retroplayer_guicontrols.a build/cores/RetroPlayer/guibridge/retroplayer_guibridge.a build/cores/RetroPlayer/cheevos/retroplayer_cheevos.a build/cores/RetroPlayer/buffers/video/rp-buffers-video.a build/cores/RetroPlayer/buffers/rp-buffers.a build/cores/RetroPlayer/audio/rp_audio.a build/cores/RetroPlayer/retroplayer.a build/pvr/windows/pvr_windows.a build/pvr/timers/pvr_timers.a build/pvr/settings/pvr_settings.a build/pvr/recordings/pvr_recordings.a build/pvr/providers/pvr_providers.a build/pvr/guilib/guiinfo/pvr_guilib_guiinfo.a build/pvr/guilib/pvr_guilib.a build/pvr/filesystem/pvr_filesystem.a build/pvr/epg/pvr_epg.a build/pvr/dialogs/pvr_dialogs.a build/pvr/channels/pvr_channels.a build/pvr/addons/pvr_addons.a build/pvr/pvr.a build/profiles/windows/profiles_windows.a build/profiles/dialogs/profiles_dialogs.a build/profiles/profiles.a build/peripherals/dialogs/peripherals_dialogs.a build/peripherals/devices/peripherals_devices.a build/peripherals/bus/virtual/peripheral_bus_virtual.a build/peripherals/bus/peripherals_bus.a build/peripherals/addons/peripherals_addons.a build/peripherals/peripherals.a build/network/websocket/network_websockets.a build/network/network.a build/music/windows/music_windows.a build/music/tags/music_tags.a build/music/jobs/music_jobs.a build/music/infoscanner/music_infoscanner.a build/music/dialogs/music_dialogs.a build/music/music.a build/drm/drm.a build/media/media.a build/interfaces/json-rpc/jsonrpc_interface.a build/interfaces/info/info_interface.a build/interfaces/generic/generic_interface.a build/interfaces/builtins/interfaces_builtins.a build/interfaces/interfaces.a build/games/windows/gameswindows.a build/games/tags/gametags.a build/games/ports/windows/games_ports_windows.a build/games/ports/types/games_ports_types.a build/games/ports/input/games_ports_input.a build/games/dialogs/osd/gameosddialogs.a build/games/dialogs/gamedialogs.a build/games/controllers/windows/games_controller_windows.a build/games/controllers/types/games_controller_types.a build/games/controllers/input/games_controller_input.a build/games/controllers/guicontrols/games_controller_guicontrols.a build/games/controllers/dialogs/games_controller_dialogs.a build/games/controllers/games_controller.a build/games/agents/games_agents.a build/games/addons/streams/game_addon_streams.a build/games/addons/input/gameinput.a build/games/addons/cheevos/gamecheevos.a build/games/addons/gameaddons.a build/games/games.a build/filesystem/videodatabase/videodatabasedirectory.a build/filesystem/musicdatabase/musicdatabasedirectory.a build/filesystem/filesystem.a build/kissfft/kissfft.a build/events/windows/events_windows.a build/events/events.a build/cores/playercorefactory/playercorefactory.a build/cores/paplayer/paplayer.a build/cores/externalplayer/externalplayer.a build/cores/dll-loader/exports/util/exports_utils.a build/cores/dll-loader/exports/dllexports.a build/cores/dll-loader/dllloader.a build/cores/audioengine/audioengine.a build/cores/cores.a build/windowing/X11/windowing_X11.a build/cores/VideoPlayer/Process/X11/processX11.a build/cores/RetroPlayer/process/X11/rp-process-x11.a -Wl,--no-whole-archive libkodi.a -pthread /usr/local/lib/libbluray.so /usr/local/lib/libdav1d.so /usr/local/lib/libiso9660++.so /usr/local/lib/libiso9660.so /usr/local/lib/libcdio.so /usr/local/lib/libpython3.9.so /usr/local/lib/libva.so /usr/local/lib/libva-drm.so /usr/local/lib/libva-x11.so /usr/local/lib/libvdpau.so /usr/local/lib/libGL.so /usr/local/lib/libass.so /usr/local/lib/libcdio.so /usr/local/lib/libcrossguid.so /usr/local/lib/libuuid.so /usr/local/lib/libcurl.so /usr/local/lib/libavcodec.so /usr/local/lib/libavfilter.so /usr/local/lib/libavformat.so /usr/local/lib/libavutil.so /usr/local/lib/libswscale.so /usr/local/lib/libswresample.so /usr/local/lib/libpostproc.so -L/usr/local/lib -lavcodec -lavfilter -lavformat -lavutil -lswscale -lswresample -lpostproc /usr/local/lib/libfmt.so /usr/local/lib/libfreetype.so /usr/local/lib/libfribidi.so /usr/local/lib/libfstrcmp.so /usr/local/lib/libharfbuzz.so -lc build/lib/libdvdnav.a build/lib/libdvdread.a build/lib/libdvdcss.a /usr/local/lib/liblzo2.so /usr/lib/libssl.so /usr/lib/libcrypto.so /usr/local/lib/libpcrecpp.so /usr/local/lib/libpcre.so /usr/local/lib/libspdlog.so /usr/local/lib/libsqlite3.so /usr/local/lib/libtag.so /usr/local/lib/libtinyxml.so /usr/lib/libz.so /usr/local/lib/libGL.so /usr/local/lib/libEGL.so /usr/local/lib/libX11.so /usr/local/lib/libXext.so /usr/local/lib/libXrandr.so /usr/local/lib/libdrm.so /usr/lib/libusb.so build/swig/libpython_binding.a build/interfaces/python/python_interface.a build/interfaces/legacy/legacy_interface.a build/rendering/gl/rendering_gl.a build/cdrip/cdrip.a build/windowing/linux/windowing_linux.a build/platform/posix/utils/platform_posix_utils.a build/platform/posix/threads/platform_posix_threads.a build/platform/posix/storage/discs/platform_posix_storage_discs.a build/platform/posix/network/platform_posix_network.a build/platform/posix/filesystem/platform_posix_filesystem.a build/platform/posix/platform_posix.a build/platform/linux/storage/platform_linux_storage.a build/platform/linux/powermanagement/platform_linux_powermanagement.a build/platform/linux/peripherals/platform_linux_peripherals.a build/platform/freebsd/network/platform_freebsd_network.a build/platform/freebsd/freebsdsupport.a build/platform/common/speech/platform_common_speech.a build/input/touch/generic/input_touch_generic.a build/input/touch/input_touch.a build/cores/VideoPlayer/videorenderers/shaders/videoshaders.a build/cores/VideoPlayer/videorenderers/hwdec/videorenderers_hwdec.a build/cores/VideoPlayer/videorenderers/videorenderers.a build/cores/VideoPlayer/process/process.a build/cores/VideoPlayer/subtitles/webvtt/subtitles_webvtt.a build/cores/VideoPlayer/subtitles/dvdsubtitles.a build/cores/VideoPlayer/inputstreams/dvdinputstreams.a build/cores/VideoPlayer/demuxers/dvddemuxers.a build/cores/VideoPlayer/codecs/video/dvdvideocodecs.a build/cores/VideoPlayer/codecs/overlay/dvdoverlaycodecs.a build/cores/VideoPlayer/codecs/audio/dvdaudiocodecs.a build/cores/VideoPlayer/codecs/dvdcodecs.a build/cores/VideoPlayer/Buffers/videoplayer-buffers.a build/cores/VideoPlayer/VideoPlayer.a build/video/windows/video_windows.a build/video/tags/video_tags.a build/video/jobs/video_jobs.a build/video/dialogs/video_dialogs.a build/video/video.a build/windows/windows.a build/windowing/windowing.a build/weather/weather.a build/view/view.a build/utils/utils.a build/threads/threads.a build/storage/storage.a build/rendering/rendering.a build/programs/programs.a build/powermanagement/powermanagement.a build/playlists/playlists.a build/platform/platform_common.a build/pictures/pictures.a build/messagingHelpers/messagingHelpers.a build/messaging/messaging.a build/listproviders/listproviders.a build/input/mouse/generic/input_mouse_generic.a build/input/mouse/input_mouse.a build/input/keyboard/generic/input_keyboard_generic.a build/input/keyboard/input_keyboard.a build/input/joysticks/keymaps/input_joystick_keymaps.a build/input/joysticks/generic/input_joystick_generic.a build/input/joysticks/dialogs/input_joystick_dialogs.a build/input/joysticks/input_joystick.a build/input/button/input_button.a build/input/actions/input_actions.a build/input/input.a build/guilib_guiinfo/guilib_guiinfo.a build/guilib/guilib.a build/favourites/favourites.a build/dialogs/dialogs.a build/dbwrappers/dbwrappers.a build/commons/commons.a build/application/application.a build/addons_settings/addons_settings.a build/addons_interfaces_gui_dialogs/addons_interfaces_gui_dialogs.a build/addons_interfaces_gui_controls/addons_interfaces_gui_controls.a build/addons_interfaces_gui/addons_interfaces_gui.a build/addons_interfaces/addons_interfaces.a build/addons_gui_skin/addons_gui_skin.a build/addons_gui/addons_gui.a build/addons_binary-addons/addons_binary-addons.a build/addons_addoninfo/addons_addoninfo.a build/addons/addons.a build/xbmc/xbmc.a build/settings/windows/settings_windows.a build/settings/lib/settings_lib.a build/settings/dialogs/settings_dialogs.a build/settings/settings.a build/cores/RetroPlayer/streams/memory/retroplayer_memory.a build/cores/RetroPlayer/streams/retroplayer_streams.a build/cores/RetroPlayer/savestates/retroplayer_savestates.a build/cores/RetroPlayer/rendering/VideoRenderers/rp-videorenderers.a build/cores/RetroPlayer/rendering/rp-rendering.a build/cores/RetroPlayer/process/rp-process.a build/cores/RetroPlayer/playback/retroplayer_playback.a build/cores/RetroPlayer/guiwindows/retroplayer_guiwindows.a build/cores/RetroPlayer/guiplayback/retroplayer_guiplayback.a build/cores/RetroPlayer/guicontrols/retroplayer_guicontrols.a build/cores/RetroPlayer/guibridge/retroplayer_guibridge.a build/cores/RetroPlayer/cheevos/retroplayer_cheevos.a build/cores/RetroPlayer/buffers/video/rp-buffers-video.a build/cores/RetroPlayer/buffers/rp-buffers.a build/cores/RetroPlayer/audio/rp_audio.a build/cores/RetroPlayer/retroplayer.a build/pvr/windows/pvr_windows.a build/pvr/timers/pvr_timers.a build/pvr/settings/pvr_settings.a build/pvr/recordings/pvr_recordings.a build/pvr/providers/pvr_providers.a build/pvr/guilib/guiinfo/pvr_guilib_guiinfo.a build/pvr/guilib/pvr_guilib.a build/pvr/filesystem/pvr_filesystem.a build/pvr/epg/pvr_epg.a build/pvr/dialogs/pvr_dialogs.a build/pvr/channels/pvr_channels.a build/pvr/addons/pvr_addons.a build/pvr/pvr.a build/profiles/windows/profiles_windows.a build/profiles/dialogs/profiles_dialogs.a build/profiles/profiles.a build/peripherals/dialogs/peripherals_dialogs.a build/peripherals/devices/peripherals_devices.a build/peripherals/bus/virtual/peripheral_bus_virtual.a build/peripherals/bus/peripherals_bus.a build/peripherals/addons/peripherals_addons.a build/peripherals/peripherals.a build/network/websocket/network_websockets.a build/network/network.a build/music/windows/music_windows.a build/music/tags/music_tags.a build/music/jobs/music_jobs.a build/music/infoscanner/music_infoscanner.a build/music/dialogs/music_dialogs.a build/music/music.a build/drm/drm.a build/media/media.a build/interfaces/json-rpc/jsonrpc_interface.a build/interfaces/info/info_interface.a build/interfaces/generic/generic_interface.a build/interfaces/builtins/interfaces_builtins.a build/interfaces/interfaces.a build/games/windows/gameswindows.a build/games/tags/gametags.a build/games/ports/windows/games_ports_windows.a build/games/ports/types/games_ports_types.a build/games/ports/input/games_ports_input.a build/games/dialogs/osd/gameosddialogs.a build/games/dialogs/gamedialogs.a build/games/controllers/windows/games_controller_windows.a build/games/controllers/types/games_controller_types.a build/games/controllers/input/games_controller_input.a build/games/controllers/guicontrols/games_controller_guicontrols.a build/games/controllers/dialogs/games_controller_dialogs.a build/games/controllers/games_controller.a build/games/agents/games_agents.a build/games/addons/streams/game_addon_streams.a build/games/addons/input/gameinput.a build/games/addons/cheevos/gamecheevos.a build/games/addons/gameaddons.a build/games/games.a build/filesystem/videodatabase/videodatabasedirectory.a build/filesystem/musicdatabase/musicdatabasedirectory.a build/filesystem/filesystem.a build/kissfft/kissfft.a build/events/windows/events_windows.a build/events/events.a build/cores/playercorefactory/playercorefactory.a build/cores/paplayer/paplayer.a build/cores/externalplayer/externalplayer.a build/cores/dll-loader/exports/util/exports_utils.a build/cores/dll-loader/exports/dllexports.a build/cores/dll-loader/dllloader.a build/cores/audioengine/audioengine.a build/cores/cores.a build/windowing/X11/windowing_X11.a build/cores/VideoPlayer/Process/X11/processX11.a build/cores/RetroPlayer/process/X11/rp-process-x11.a /usr/local/lib/libfstrcmp.so /usr/local/lib/libcdio.so /usr/local/lib/libpython3.9.so /usr/local/lib/libva.so /usr/local/lib/libva-drm.so /usr/local/lib/libva-x11.so /usr/local/lib/libvdpau.so /usr/local/lib/libass.so /usr/local/lib/libcrossguid.so /usr/local/lib/libuuid.so /usr/local/lib/libcurl.so /usr/local/lib/libavcodec.so /usr/local/lib/libavfilter.so /usr/local/lib/libavformat.so /usr/local/lib/libavutil.so /usr/local/lib/libswscale.so /usr/local/lib/libswresample.so /usr/local/lib/libpostproc.so -lavcodec -lavfilter -lavformat -lavutil -lswscale -lswresample -lpostproc /usr/local/lib/libfmt.so /usr/local/lib/libfreetype.so /usr/local/lib/libfribidi.so /usr/local/lib/libharfbuzz.so -lc build/lib/libdvdnav.a build/lib/libdvdread.a build/lib/libdvdcss.a /usr/local/lib/liblzo2.so /usr/lib/libssl.so /usr/lib/libcrypto.so /usr/local/lib/libpcrecpp.so /usr/local/lib/libpcre.so /usr/local/lib/libspdlog.so /usr/local/lib/libsqlite3.so /usr/local/lib/libtag.so /usr/local/lib/libtinyxml.so /usr/lib/libz.so /usr/local/lib/libEGL.so /usr/local/lib/libX11.so /usr/local/lib/libXext.so /usr/local/lib/libXrandr.so /usr/local/lib/libdrm.so /usr/lib/libusb.so 
ld: error: undefined symbol: EVP_MD_CTX_destroy
>>> referenced by Digest.cpp
>>>               Digest.cpp.o:(KODI::UTILITY::CDigest::MdCtxDeleter::operator()(env_md_ctx_st*)) in archive build/utils/utils.a
>>> referenced by Digest.cpp
>>>               Digest.cpp.o:(KODI::UTILITY::CDigest::Calculate(KODI::UTILITY::CDigest::Type, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)) in archive build/utils/utils.a
>>> referenced by Digest.cpp
>>>               Digest.cpp.o:(KODI::UTILITY::CDigest::Calculate(KODI::UTILITY::CDigest::Type, void const*, unsigned long)) in archive build/utils/utils.a
>>> referenced 1 more times

ld: error: undefined symbol: EVP_MD_CTX_create
>>> referenced by Digest.cpp
>>>               Digest.cpp.o:(KODI::UTILITY::CDigest::CDigest(KODI::UTILITY::CDigest::Type)) in archive build/utils/utils.a
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[4]: *** [CMakeFiles/kodi.dir/build.make:547: kodi-x11] Error 1
gmake[4]: Leaving directory '/tmp/ports/usr/ports/multimedia/kodi/work/.build'
gmake[3]: *** [CMakeFiles/Makefile2:4741: CMakeFiles/kodi.dir/all] Error 2
gmake[3]: Leaving directory '/tmp/ports/usr/ports/multimedia/kodi/work/.build'
gmake[2]: *** [Makefile:139: all] Error 2
gmake[2]: Leaving directory '/tmp/ports/usr/ports/multimedia/kodi/work/.build'
Comment 1 Ivan Rozhuk 2023-09-03 23:59:28 UTC 
Created attachment 244619 [details]
patch
Comment 2 yzrh 2023-09-07 14:22:25 UTC 
Sorry for delay.  I think it is safe to simply swap the calls,
as from OpenSSL 1.1.0, EVP_MD_CTX_create() and EVP_MD_CTX_destroy()
are renamed anyway.  It was quick for LibreSSL to remove all
the (backward compatible) references.
Comment 3 yzrh 2023-09-07 14:24:09 UTC 
Created attachment 244696 [details]
Use new functions for *ssl
Comment 4 yzrh 2023-09-07 14:24:57 UTC 
Created attachment 244697 [details]
testport log

Builds fine, so it seems.
Comment 5 Ivan Rozhuk 2023-09-20 10:15:46 UTC 
Current patches are wrong.

...
-- Found OpenSSL: /usr/lib/libcrypto.so (found suitable version "1.1.1v", minimum required is "1.1.0")
...

kodi use include files from libressl but links with base OpenSSL.
Same issue was here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273609
Fast fix is: CMAKE_ARGS+= -DOPENSSL_ROOT_DIR=${OPENSSLBASE}
But probably this must be handled by build system, due to affect many ports.