Summary: | VLAN issue after upgrading from stable/13 to main or stable/14 - kernel without COMPAT_FREEBSD12 | ||
---|---|---|---|
Product: | Base System | Reporter: | Herbert J. Skuhra <herbert> |
Component: | kern | Assignee: | Dag-Erling Smørgrav <des> |
Status: | Closed FIXED | ||
Severity: | Affects Many People | CC: | ae, des, eugen, melifaro, pi |
Priority: | --- | Keywords: | regression |
Version: | 14.0-STABLE | Flags: | des:
mfc-stable14+
des: mfc-stable13+ |
Hardware: | Any | ||
OS: | Any |
Description
Herbert J. Skuhra
2023-09-03 09:40:42 UTC
Alexander, can you see a reason not to just remove the #ifdef? A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=b451dcc84f1cfd1d14ede8a53d1d8359c9b85c94 commit b451dcc84f1cfd1d14ede8a53d1d8359c9b85c94 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-04 23:26:07 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-04 23:26:18 +0000 if_vlan: Always default to 802.1q. There is no reason for this fallback to be conditional on COMPAT_FREEBSD12. PR: 273539 MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: melifaro, allanjude Differential Revision: https://reviews.freebsd.org/D41717 sys/net/if_vlan.c | 5 ----- 1 file changed, 5 deletions(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=a0fea1dc59d5eae266bef72e8f6ba9ca9d9f9691 commit a0fea1dc59d5eae266bef72e8f6ba9ca9d9f9691 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-04 23:26:07 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-07 20:28:31 +0000 if_vlan: Always default to 802.1q. There is no reason for this fallback to be conditional on COMPAT_FREEBSD12. PR: 273539 MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: melifaro, allanjude Differential Revision: https://reviews.freebsd.org/D41717 (cherry picked from commit b451dcc84f1cfd1d14ede8a53d1d8359c9b85c94) Approved by: re (gjb) sys/net/if_vlan.c | 5 ----- 1 file changed, 5 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=6d5d8c7b2c745f29533a63d6bced705b9ecb1a57 commit 6d5d8c7b2c745f29533a63d6bced705b9ecb1a57 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-04 23:26:07 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-08 10:09:23 +0000 if_vlan: Always default to 802.1q. There is no reason for this fallback to be conditional on COMPAT_FREEBSD12. PR: 273539 MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: melifaro, allanjude Differential Revision: https://reviews.freebsd.org/D41717 (cherry picked from commit b451dcc84f1cfd1d14ede8a53d1d8359c9b85c94) sys/net/if_vlan.c | 5 ----- 1 file changed, 5 deletions(-) |