Summary: | freebsd-update fills up /var/db/freebsd-update/files and never cleans them | ||
---|---|---|---|
Product: | Base System | Reporter: | David Chisnall <theraven> |
Component: | misc | Assignee: | Ed Maste <emaste> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | cperciva, emaste, grahamperrin |
Priority: | --- | ||
Version: | CURRENT | ||
Hardware: | Any | ||
OS: | Any | ||
URL: | https://reviews.freebsd.org/D42022 | ||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263290 |
Description
David Chisnall
![]() ![]() Yes, all of those files will be used if you `freebsd-update rollback` all the way back in history. When I first designed this code (for security updates, not upgrading between releases) the number of files was small so it was never an issue. We should probably have a `freebsd-update purge` which make it impossible to rollback and cleans up all those files. OTOH we're going to be moving to pkgbase any decade now and freebsd-update won't be needed any more... right...? (In reply to Colin Percival from comment #1) > OTOH we're going to be moving to pkgbase any decade now and freebsd-update won't be needed any more... right...? Yup, any decade now... (In reply to David Chisnall from comment #2) pkgbase packages will be provided from FreeBSD 14.0 on, as a sort of technology preview. They won't yet be used by the FreeBSD installer etc., but will be available for experimentation and use by projects like dfr's cloud image creation tools. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=30beebe444f5f415a388be9df91107246bd32674 commit 30beebe444f5f415a388be9df91107246bd32674 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-09-29 15:47:41 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-04 14:45:57 +0000 freebsd-update: add a note about when files may be deleted Files under /var/db/freebsd-update are required during the upgrade process, and to support rollback. They may be deleted if no upgrade is in progress and rollback will not be required. PR: 273601 Reviewed by: bcr Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42022 usr.sbin/freebsd-update/freebsd-update.8 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ffe4456d7d9f2c6bb14e9b747766adc3042f0b9e commit ffe4456d7d9f2c6bb14e9b747766adc3042f0b9e Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-09-29 15:47:41 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-13 14:13:38 +0000 freebsd-update: add a note about when files may be deleted Files under /var/db/freebsd-update are required during the upgrade process, and to support rollback. They may be deleted if no upgrade is in progress and rollback will not be required. PR: 273601 Reviewed by: bcr Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42022 (cherry picked from commit 30beebe444f5f415a388be9df91107246bd32674) usr.sbin/freebsd-update/freebsd-update.8 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=4dd8132fc565cb08b92a918a1cae52f246417999 commit 4dd8132fc565cb08b92a918a1cae52f246417999 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-09-29 15:47:41 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-13 17:27:03 +0000 freebsd-update: add a note about when files may be deleted Files under /var/db/freebsd-update are required during the upgrade process, and to support rollback. They may be deleted if no upgrade is in progress and rollback will not be required. PR: 273601 Reviewed by: bcr Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42022 (cherry picked from commit 30beebe444f5f415a388be9df91107246bd32674) (cherry picked from commit ffe4456d7d9f2c6bb14e9b747766adc3042f0b9e) usr.sbin/freebsd-update/freebsd-update.8 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=80b003e816849b7809e7c64e01bf3acd543e4357 commit 80b003e816849b7809e7c64e01bf3acd543e4357 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-09-29 15:47:41 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-13 23:17:39 +0000 freebsd-update: add a note about when files may be deleted Files under /var/db/freebsd-update are required during the upgrade process, and to support rollback. They may be deleted if no upgrade is in progress and rollback will not be required. PR: 273601 Reviewed by: bcr Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42022 (cherry picked from commit 30beebe444f5f415a388be9df91107246bd32674) (cherry picked from commit ffe4456d7d9f2c6bb14e9b747766adc3042f0b9e) Approved by: re (gjb) usr.sbin/freebsd-update/freebsd-update.8 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) ^Triage: assign to committer who made the change and MFCed. |