Bug 273675

Summary: devel/pcsc-cyberjack: Fails to build with GCC 13: error: expected identifier before '__is_convertible'
Product: Ports & Packages Reporter: Lorenzo Salvadore <salvadore>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz, tm
Priority: --- Flags: fuz: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Set USE_GCC=12 salvadore: maintainer-approval? (tm)

Description Lorenzo Salvadore freebsd_committer freebsd_triage 2023-09-10 07:19:34 UTC 
This bug report blocks the update of GCC_DEFAULT to 13. This webpage can help finding ta fix: https://gcc.gnu.org/gcc-13/porting_to.html

libtool: compile:  g++13 -DHAVE_CONFIG_H -I. -I.. -I../include -I../include/driver -I../include/firmware -Iausb -I/usr/local/include/PCSC -pthread -DBUILDING_CYBERJACK -DCYBERJACK_CONFIG_FILE=\"/usr/local/etc/cyberjack.conf\" -I/usr/local/include -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13 -Wno-c++11-narrowing -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13 -Wall -MT BaseTranslater.lo -MD -MP -MF .deps/BaseTranslater.Tpo -c BaseTranslater.cpp -o BaseTranslater.o >/dev/null 2>&1
In file included from /usr/include/c++/v1/__functional/weak_result_type.h:16,
                 from /usr/include/c++/v1/__functional/invoke.h:14,
                 from /usr/include/c++/v1/__functional_base:15,
                 from /usr/include/c++/v1/string:520,
                 from BaseCommunication.h:8,
                 from BaseCommunication.cpp:2:
/usr/include/c++/v1/type_traits:1770:8: error: expected identifier before '__is_convertible'
 1770 | struct __is_convertible
      |        ^~~~~~~~~~~~~~~~

Full log: https://pkg-status.freebsd.org/package18/data/124amd64-default-foo/2023-09-06_17h55m19s/logs/errors/pcsc-cyberjack-3.99.5.f.s15_1.log

There are other bugs similar to this one, such as #273671 or #273674.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2024-01-08 11:00:43 UTC 
Created attachment 247527 [details]
Set USE_GCC=12

Until a better solution is found, this will allow the GCC_DEFAULT update to version 13 to get forward.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-23 10:30:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=992e5c9046d93e84e661a236eceee3c4d7708b08

commit 992e5c9046d93e84e661a236eceee3c4d7708b08
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2024-01-08 10:56:25 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2024-01-23 10:21:35 +0000

    devel/pcsc-cyberjack: Set USE_GCC=12

    Until a better solution is found, this will allow the GCC_DEFAULT update
    to version 13 to get forward.

    PR:             273675
    Approved by:    maintainer timeout (2 weeks) and portmgr (blanket)

 devel/pcsc-cyberjack/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 4 Lorenzo Salvadore freebsd_committer freebsd_triage 2024-01-23 10:37:13 UTC 
Sorry, this should not have been closed since the bug is still there. Only the block for the GCC 13 as default version should have been removed.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-01-23 12:48:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37fed8066f0919c491069d3c13cbb9aad9f06c1e

commit 37fed8066f0919c491069d3c13cbb9aad9f06c1e
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2024-01-23 12:46:56 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2024-01-23 12:46:56 +0000

    devel/pcsc-cyberjack: the port had been improved (+)

    - Chase HTTP/1.1 redirections in MASTER_SITES and WWW line
    - Tame dos2unix(1) to not touch every file, cleanup Makefile
    - No longer needlessly depends on GNU libstdc++ and make(1)

    PR:     273675 (inspired by)

 devel/pcsc-cyberjack/Makefile                    | 25 ++++++++----------------
 devel/pcsc-cyberjack/files/patch-ifd-Makefile.am |  5 ++++-
 2 files changed, 12 insertions(+), 18 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2024-03-16 12:49:36 UTC 
Maintainer told me (here at a local event) that he no longer runs FreeBSD and thus cannot debug and/or fix this issue.

@lorenzo are you working on a solution?  If not, I could go and take a look.
Comment 7 Lorenzo Salvadore freebsd_committer freebsd_triage 2024-03-21 10:40:12 UTC 
(In reply to Robert Clausecker from comment #6)

No, I am not working at a solution: unfortunately there is already too much stuff that I need to work on. Feel free to work on this bug and assign it to yourself if you would like it. Thanks!
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2024-03-21 10:43:13 UTC 
Self-assign.  Maintainer is no longer able to work on this problem on account of no longer running any equipment with FreeBSD.
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2024-10-06 15:10:03 UTC 
Issue was already fixed by danfe a while ago; port no longer needs gcc to build.