Bug 273676

Summary: emulators/emulationstation: Fails to build with GCC 13: error: expected identifier before '__is_convertible'
Product: Ports & Packages Reporter: Lorenzo Salvadore <salvadore>
Component: Individual Port(s)Assignee: Lorenzo Salvadore <salvadore>
Status: Closed FIXED    
Severity: Affects Only Me CC: freebsd
Priority: --- Flags: bugzilla: maintainer-feedback? (freebsd)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 273397    
Attachments:
Description Flags
Update and fix salvadore: maintainer-approval? (freebsd)

Description Lorenzo Salvadore freebsd_committer freebsd_triage 2023-09-10 07:22:08 UTC 
This bug report blocks the update of GCC_DEFAULT to 13. This webpage can help finding ta fix: https://gcc.gnu.org/gcc-13/porting_to.html

===>  Building for emulationstation-2.9.4_5
[  0% 3/108] /usr/local/bin/g++13 -DAPPDATANAME=\"EmulationStation\" -DUSE_OPENGL_14 -I/wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13 -std=c++11 -Wno-attributes -O2 -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13  -DNDEBUG -MD -MT external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o -MF external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o.d -o external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o -c /wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg/src/nanosvg_impl.cpp
FAILED: external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o 
/usr/local/bin/g++13 -DAPPDATANAME=\"EmulationStation\" -DUSE_OPENGL_14 -I/wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13 -std=c++11 -Wno-attributes -O2 -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13  -DNDEBUG -MD -MT external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o -MF external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o.d -o external/nanosvg/CMakeFiles/nanosvg.dir/src/nanosvg_impl.cpp.o -c /wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg/src/nanosvg_impl.cpp
In file included from /usr/include/c++/v1/math.h:309,
                 from /wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg/nanosvg.h:190,
                 from /wrkdirs/usr/ports/emulators/emulationstation/work/EmulationStation-2.9.4/external/nanosvg/src/nanosvg_impl.cpp:5:
/usr/include/c++/v1/type_traits:1770:8: error: expected identifier before '__is_convertible'
 1770 | struct __is_convertible
      |        ^~~~~~~~~~~~~~~~

Full log: https://pkg-status.freebsd.org/package18/data/124amd64-default-foo/2023-09-06_17h55m19s/logs/errors/emulationstation-2.9.4_5.log

There are other bugs similar to this one, such as #273671 or #273674.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-12-27 11:17:25 UTC 
Created attachment 247286 [details]
Update and fix

This patch updates the port and fixes the build with GCC 13.
Does the maintainer approve it?
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-23 10:31:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c48fd2014e721f0e4b3a76ef30c2592b75ac85e9

commit c48fd2014e721f0e4b3a76ef30c2592b75ac85e9
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2023-12-26 15:54:03 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2024-01-23 10:30:25 +0000

    emulators/emulationstation: Update to v2.11.2

    This also fixes the build with GCC 13 [1].

    Changes:
    https://github.com/RetroPie/EmulationStation/compare/v2.9.4...v2.11.2

    PR:             273676 [1]
    Approved by:    maintainer timeout (> 3 weeks)

 emulators/emulationstation/Makefile                |  9 +-
 emulators/emulationstation/distinfo                |  6 +-
 .../files/patch-es-app_src_SystemData.h (new)      | 11 +++
 .../patch-es-core_src_utils_FileSystemUtil.cpp     | 96 ++++++++++++++++------
 .../patch-es-core_src_utils_TimeUtil.h (gone)      | 10 ---
 emulators/emulationstation/pkg-plist               |  1 +
 6 files changed, 91 insertions(+), 42 deletions(-)