Bug 27374

Summary: Added bold color to the /bin/ls color support
Product: Base System Reporter: fracture <fracture>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.3-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description fracture 2001-05-16 08:20:01 UTC
        /bin/ls on freebsd has a limited support for colors where, if envoked with -G or
        if it finds CLICOLOR in the environment it uses the environment variable LSCOLORS
        to highlight differnt file types with differnt colors.

        the LSCOLORS variable is just a string of 0-7's for the fg and bg of the color, or
        and x to leave it alone.  This means that on, for example, the vga console, it is
        impossible to get a yellow color because yellow is really bold brown (color 3).

        I've made a little patch that allows the LSCOLORS to contain ),!,@,#,$,%,^,& (the
        shift of 0-7) to do a bold color for a particular file type.

How-To-Repeat: 	for example, after applying the patch, this will do yellow for directories on syscons;
	% setenv LSCOLORS \#x6x50502xxxxx2124xxxx
	% ls -GF
Comment 1 Peter Pentchev 2001-05-16 10:02:35 UTC
On Wed, May 16, 2001 at 12:40:05AM -0700, Jordan DeLong wrote:
> The following reply was made to PR bin/27374; it has been noted by GNATS.
> 
> From: Jordan DeLong <fracture@allusion.net>
> To: bug-followup@freebsd.org
> Cc:  
> Subject: Re: bin/27374
> Date: Wed, 16 May 2001 00:34:49 -0700
> 
>  --b5gNqxB1S1yM7hjW
>  Content-Type: multipart/mixed; boundary="G4iJoqBmSsgzjUCe"
>  Content-Disposition: inline
>  
>  
>  --G4iJoqBmSsgzjUCe
>  Content-Type: text/plain; charset=us-ascii
>  Content-Disposition: inline
>  Content-Transfer-Encoding: quoted-printable
>  
>  I forgot to make appropriate modifications to the man page in my patch,
>  so here's another patch for ls.1.

Is there a reason for your removing all the 'Sy' macros?  I think it is
a Good Thing(tm) for the color specifiers to stand out..

G'luck,
Peter

-- 
I've heard that this sentence is a rumor.
Comment 2 fracture 2001-05-16 10:23:18 UTC
> Is there a reason for your removing all the 'Sy' macros?  I think it is
> a Good Thing(tm) for the color specifiers to stand out..


Nope, there's no good reason.  And I'd agree that it'd be nice (as well as
consistent with the rest of the man page) to keep them there.  Unfortunatly
I know very little about troff and mdoc stuff and when I added the ) and !
lines they weren't standing out like the other ones, and I decided it'd be
better to at least submit the neccesary content modifications to the manual
page even if I couldn't figure that formatting part out.  So, if you know
what I was doing wrong with the ) and ! (they just looked like .It Sy !),
then they could probably be easily put back in.

-- 
Jordan DeLong
fracture@allusion.net
Comment 3 joe freebsd_committer freebsd_triage 2001-12-28 18:17:13 UTC
State Changed
From-To: open->closed

I've committed bold colour support to -current.  Instead of 
using the suggested method, I instead chose to use the characters 
a-h to define the colours and the upper case variants for the 
bold versions of the same colours.