Bug 273807
| Summary: | tcpdump is not able to set honor the timezone of the PC as set in /etc/localtime | ||
|---|---|---|---|
| Product: | Base System | Reporter: | mike |
| Component: | bin | Assignee: | Dag-Erling Smørgrav <des> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | CC: | des, grahamperrin, jrm, pi |
| Priority: | --- | Flags: | des:
mfc-stable14+
|
| Version: | 14.0-STABLE | ||
| Hardware: | amd64 | ||
| OS: | Any | ||
| See Also: | https://reviews.freebsd.org/D41880 | ||
|
Description
mike
2023-09-14 23:54:33 UTC
The patch in https://github.com/the-tcpdump-group/tcpdump/pull/1084 should be sufficient in principle but does not appear to work in practice. This is probably due to a bug in our tzcode adaptations. I will investigate further. Correction: the patch works as long as you don't have WITH_DETECT_TZ_CHANGES defined, and most people don't. Thanks both. Dag-Erling, I just applied your patch to my CURRENT system (main-n265074-6b635c74fd41), and the log entries are displayed in local time. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=7e0a7ef95fac1183854cab662bd9afa4647422d6 commit 7e0a7ef95fac1183854cab662bd9afa4647422d6 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-15 21:36:41 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-15 21:36:41 +0000 tcpdump: Initialize tzcode early. An explicit tzset() call is usually not needed as it happens implicitly the first time we call localtime() or mktime(), but in some cases (sandboxing, chroot) this may be too late. PR: 273807 MFC after: 3 days Reviewed by: jrm Differential Revision: https://reviews.freebsd.org/D41880 contrib/tcpdump/tcpdump.c | 2 ++ 1 file changed, 2 insertions(+) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c7e9092572cde1a3b9d8a6dc8fb586d1deecef07 commit c7e9092572cde1a3b9d8a6dc8fb586d1deecef07 Author: Joseph Mingrone <jrm@FreeBSD.org> AuthorDate: 2023-09-18 13:26:21 +0000 Commit: Renato Botelho <garga@FreeBSD.org> CommitDate: 2023-09-18 13:28:51 +0000 net/tcpdump: Patch to honour local timezone Summary: Discussion: https://lists.freebsd.org/archives/freebsd-stable/2023-September/001448.html PR: 273807 (src patch) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D41886 net/tcpdump/Makefile | 4 ++++ net/tcpdump/distinfo | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=51d54ed6151b5381bca703d85762d9d054463003 commit 51d54ed6151b5381bca703d85762d9d054463003 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-15 21:36:41 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-19 10:10:21 +0000 tcpdump: Initialize tzcode early. An explicit tzset() call is usually not needed as it happens implicitly the first time we call localtime() or mktime(), but in some cases (sandboxing, chroot) this may be too late. PR: 273807 MFC after: 3 days Reviewed by: jrm Differential Revision: https://reviews.freebsd.org/D41880 (cherry picked from commit 7e0a7ef95fac1183854cab662bd9afa4647422d6) contrib/tcpdump/tcpdump.c | 2 ++ 1 file changed, 2 insertions(+) A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=c1b6110df0405b53e0191c5cea42a85dc19ffe46 commit c1b6110df0405b53e0191c5cea42a85dc19ffe46 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-09-15 21:36:41 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-09-19 10:45:29 +0000 tcpdump: Initialize tzcode early. An explicit tzset() call is usually not needed as it happens implicitly the first time we call localtime() or mktime(), but in some cases (sandboxing, chroot) this may be too late. PR: 273807 MFC after: 3 days Reviewed by: jrm Differential Revision: https://reviews.freebsd.org/D41880 Approved by: re (kib) (cherry picked from commit 7e0a7ef95fac1183854cab662bd9afa4647422d6) (cherry picked from commit 51d54ed6151b5381bca703d85762d9d054463003) contrib/tcpdump/tcpdump.c | 2 ++ 1 file changed, 2 insertions(+) |
