Bug 274013
| Summary: | security/tpm2-tools: 5.5 version fails to build if devel/openssl is installed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||
| Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | fuz, jcfyecrayz, lwhsu, tstruk | ||||
| Priority: | --- | Flags: | fuz:
merge-quarterly?
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: |
https://reviews.freebsd.org/D41802 https://github.com/tpm2-software/tpm2-tools/issues/3286 |
||||||
| Bug Depends on: | 273961 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
John Hein
2023-09-22 01:14:44 UTC
Maintainer informed via mail Shall this PR be merged into the quarterly branch? Sorry, wrong PR. It appears the maintainer does not have a bugzilla account (at least not registered to MAINTAINER email). So the maintainer feedback request flag could not be set on this bug. Comment added to review D41802. Created attachment 245318 [details]
[patch] fix lib path used for crypto checks during configure
Attached is a bug fix that works if security/openssl is installed (or not).
If someone has DEFAULT_VERSIONS=ssl:openssl it will now check the lib in /usr/local during configure. Similarly if using DEFAULT_VERSIONS=ssl:base, it looks in /usr/lib during configure.
No need to bump PORTREVISION - the package will not change if it has been successfully built. This just fixes a build failure that was not producing a package.
Verified in poudriere with DEFAULT_VERSIONS=ssl:openssl and also with DEFAULT_VERSIONS=ssl:base.
Requested maintainer approval from last committer. Maintainer does not appear to have a bugzilla account. I will add a comment in the review.
See also upstream bug report: https://github.com/tpm2-software/tpm2-tools/issues/3286 The attached patch looks ok to me. Let's use it for now if it fixes the build and I will work on an upstream patch. Thanks for fixing it. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a4f11eab468a6e3741cb8cdced5660634917120e commit a4f11eab468a6e3741cb8cdced5660634917120e Author: John Hein <jcfyecrayz@liamekaens.com> AuthorDate: 2023-09-30 21:41:46 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-04 19:59:55 +0000 security/tpm2-tools: fix build if security/openssl is installed If someone has DEFAULT_VERSIONS=ssl:openssl it will now check the lib in /usr/local during configure. Similarly if using DEFAULT_VERSIONS=ssl:base, it looks in /usr/lib during configure. PR: 274013 Approved by: tstruk@gmail.com (maintainer) MFH: 2023Q4 security/tpm2-tools/Makefile | 1 + security/tpm2-tools/files/patch-configure (new) | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+) A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=61b5d46f2faf578738ba2a4539b95adf0615dac2 commit 61b5d46f2faf578738ba2a4539b95adf0615dac2 Author: John Hein <jcfyecrayz@liamekaens.com> AuthorDate: 2023-09-30 21:41:46 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-04 20:04:13 +0000 security/tpm2-tools: fix build if security/openssl is installed If someone has DEFAULT_VERSIONS=ssl:openssl it will now check the lib in /usr/local during configure. Similarly if using DEFAULT_VERSIONS=ssl:base, it looks in /usr/lib during configure. PR: 274013 Approved by: tstruk@gmail.com (maintainer) MFH: 2023Q4 (cherry picked from commit a4f11eab468a6e3741cb8cdced5660634917120e) security/tpm2-tools/Makefile | 1 + security/tpm2-tools/files/patch-configure (new) | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+) |
