Bug 274169

Summary: net-p2p/lidarr: prefer USES=iconv over RUN_DEPENDS
Product: Ports & Packages Reporter: Dries Michiels <driesm>
Component: Individual Port(s)Assignee: Dries Michiels <driesm>
Status: Closed FIXED    
Severity: Affects Only Me CC: michiel
Priority: --- Flags: michiel: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
0001-net-p2p-arr-prefer-USES-iconv-over-RUN_DEPENDS.patch michiel: maintainer-approval+

Description Dries Michiels freebsd_committer freebsd_triage 2023-09-30 08:12:33 UTC 
Hello,

I have noticed that we are currently specifying libiconv>0:converters/libiconv as RUN_DEPENDS. But noticed we have a USES for it. Could you add a patch for converting all your ports to use the framework iconv? :)

https://cgit.freebsd.org/ports/tree/Mk/Uses/iconv.mk
Comment 1 Michiel van Baak Jansen 2023-09-30 10:49:08 UTC 
Created attachment 245329 [details]
0001-net-p2p-arr-prefer-USES-iconv-over-RUN_DEPENDS.patch

poudriere ok.
Updated and restarted all ports on my production setup, and all working as before \o/

sonarr-devel will be a seperate patch as it will be upgraded to the latest version at the same time.
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2023-10-01 08:44:02 UTC 
You can add the change for sonoarr-devel too :). This keeps the commit and PR grouped for an identical change.
Comment 3 Michiel van Baak Jansen 2023-10-01 10:20:18 UTC 
(In reply to Dries Michiels from comment #2)

sonarr-devel update is already committed: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274173
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-10-01 11:27:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0dd4888766913979a37797e7b9fe589f5de5202a

commit 0dd4888766913979a37797e7b9fe589f5de5202a
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2023-10-01 11:25:30 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2023-10-01 11:25:30 +0000

    net-p2p/*rr: switch to USES=iconv

    PR:     274169

 net-p2p/lidarr/Makefile   | 5 ++---
 net-p2p/prowlarr/Makefile | 4 ++--
 net-p2p/radarr/Makefile   | 5 ++---
 net-p2p/readarr/Makefile  | 4 ++--
 4 files changed, 8 insertions(+), 10 deletions(-)
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2023-10-01 11:28:12 UTC 
Committed, thanks!