Summary: | lang/gnat12: Fix incorrect binutils dependencies and ldconfig paths | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Nico Sonack <nsonack> | ||||
Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | agh, fuz, pi | ||||
Priority: | --- | Flags: | fuz:
maintainer-feedback+
fuz: merge-quarterly? |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274240 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274238 |
||||||
Bug Depends on: | |||||||
Bug Blocks: | 274243 | ||||||
Attachments: |
|
Description
Nico Sonack
2023-10-03 13:45:55 UTC
maintainer timeout Will MFH this patch as a bug fix. Hi, I noticed that Nico has included some much needed maintenance of the Makefile, there is still more work that can be done in this area. I have a patch that continues Nico's maintenance work, and clears most advice/warnings/errors from the various port tools. Shall I submit that patch here, or create another bug report for that? I have build tested with 12, 13, and 15 on amd64 only at the moment, however, I am building all new GNAT assets for amd64 and i386 for complete testing. Please submit a new patch. An edit to this one would require another wait for maintainer approval or timeout. Easy, thanks. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=69e85930e200e0ee30f78119063bbd43abe2be3e commit 69e85930e200e0ee30f78119063bbd43abe2be3e Author: Nico Sonack <nsonack@herrhotzenplotz.de> AuthorDate: 2023-10-01 16:57:46 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-19 07:07:28 +0000 lang/gnat12: Add missing binutils RUN_DEPENDS and fix broken library search paths Any produce binary of the gnat12 Ada compiler that had dependencies on libstdc++ from this package would result in broken binaries because no RUNPATH and no ldconfig paths were set up such that the included libstdc++ would get found. While we're at it, add the missing binutils dependency because the compiler driver would find the GNU assembler that is hardcoded in the Makefile. PR: 274239 Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de> Approved by: thierry (maintainer timeout, two weeks) MFH: 2023Q4 lang/gnat12/Makefile | 125 +++++++++++++++++++++++++++------------------------ 1 file changed, 66 insertions(+), 59 deletions(-) A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3422893f5e8dbab92b1010c5ca45b35116d241d5 commit 3422893f5e8dbab92b1010c5ca45b35116d241d5 Author: Nico Sonack <nsonack@herrhotzenplotz.de> AuthorDate: 2023-10-01 16:57:46 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-19 07:10:08 +0000 lang/gnat12: Add missing binutils RUN_DEPENDS and fix broken library search paths Any produce binary of the gnat12 Ada compiler that had dependencies on libstdc++ from this package would result in broken binaries because no RUNPATH and no ldconfig paths were set up such that the included libstdc++ would get found. While we're at it, add the missing binutils dependency because the compiler driver would find the GNU assembler that is hardcoded in the Makefile. PR: 274239 Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de> Approved by: thierry (maintainer timeout, two weeks) MFH: 2023Q4 (cherry picked from commit 69e85930e200e0ee30f78119063bbd43abe2be3e) lang/gnat12/Makefile | 125 +++++++++++++++++++++++++++------------------------ 1 file changed, 66 insertions(+), 59 deletions(-) Thank you for your contribution. (In reply to Robert Clausecker from comment #4) Done, bug #274619. Thanks. |