Bug 274292
| Summary: | Adding patch to support Realtek Killer Ethernet E2600 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Sk Razee <dragonflies> | ||||
| Component: | misc | Assignee: | Kristof Provost <kp> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | emaste, markj, net | ||||
| Priority: | --- | ||||||
| Version: | 13.2-RELEASE | ||||||
| Hardware: | amd64 | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3c871489cdd6c5606b2b1125f66b0e9b8f39561f commit 3c871489cdd6c5606b2b1125f66b0e9b8f39561f Author: Sk Razee <dragonflies@mailfence.com> AuthorDate: 2023-10-06 06:08:16 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2023-10-06 06:10:04 +0000 if_re: add Realtek Killer Ethernet E2600 IDs PR: 274292 MFC after: 1 week Reviewed by: kp Event: Oslo Hackathon at Modirum sys/dev/re/if_re.c | 2 ++ sys/dev/rl/if_rlreg.h | 1 + 2 files changed, 3 insertions(+) By the way, all credit goes to, 1. https://forums.freebsd.org/members/t-daemon.27243/ 2. https://forums.freebsd.org/members/covacat.67479/ All I did is to test and generate the patch. Thank you all for the support. ^Triage: * reopen pending MFC * assign to the resolving committer. ---- (In reply to Sk Razee from comment #2) Thanks, you may be unaware that members' profiles are not visible to the public. Found: <https://forums.freebsd.org/threads/90382/>. A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=dc80e764d682bd9b58eeec6a44ba4217444f1db1 commit dc80e764d682bd9b58eeec6a44ba4217444f1db1 Author: Sk Razee <dragonflies@mailfence.com> AuthorDate: 2023-10-06 06:08:16 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2023-10-13 07:25:32 +0000 if_re: add Realtek Killer Ethernet E2600 IDs PR: 274292 MFC after: 1 week Reviewed by: kp Event: Oslo Hackathon at Modirum (cherry picked from commit 3c871489cdd6c5606b2b1125f66b0e9b8f39561f) sys/dev/re/if_re.c | 2 ++ sys/dev/rl/if_rlreg.h | 1 + 2 files changed, 3 insertions(+) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=50cf84e93c5be087316da4495395b66793fe80d9 commit 50cf84e93c5be087316da4495395b66793fe80d9 Author: Sk Razee <dragonflies@mailfence.com> AuthorDate: 2023-10-06 06:08:16 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2023-10-13 07:25:36 +0000 if_re: add Realtek Killer Ethernet E2600 IDs PR: 274292 MFC after: 1 week Reviewed by: kp Event: Oslo Hackathon at Modirum (cherry picked from commit 3c871489cdd6c5606b2b1125f66b0e9b8f39561f) sys/dev/re/if_re.c | 2 ++ sys/dev/rl/if_rlreg.h | 1 + 2 files changed, 3 insertions(+) @kp are you interested in getting this into 14.0? (In reply to Ed Maste from comment #6) I wasn't planning to, no. (In reply to Kristof Provost from comment #7) I suppose this PR can be closed then? OTOH, it seems quite low risk to get this 14.0. (In reply to Mark Johnston from comment #8) It should be low risk, yes, but my understanding is that it's too late to merge anything other that blocking bug fixes for 14.0. (In reply to Kristof Provost from comment #9) My only counterargument is that this change of little use as an errata since we don't generate new install images, so if we want users with this hardware to be able to run 14.0 it needs to be included in the release. (In reply to Graham Perrin from comment #3) Sorry, I don't know their real names. Yes, I wasn't aware about that. A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=19232cc73b4b17246bbeec9dd133648ca1b608c0 commit 19232cc73b4b17246bbeec9dd133648ca1b608c0 Author: Sk Razee <dragonflies@mailfence.com> AuthorDate: 2023-10-06 06:08:16 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-24 01:15:26 +0000 if_re: add Realtek Killer Ethernet E2600 IDs PR: 274292 MFC after: 1 week Reviewed by: kp Event: Oslo Hackathon at Modirum (cherry picked from commit 3c871489cdd6c5606b2b1125f66b0e9b8f39561f) (cherry picked from commit 50cf84e93c5be087316da4495395b66793fe80d9) Approved by: re (gjb) sys/dev/re/if_re.c | 2 ++ sys/dev/rl/if_rlreg.h | 1 + 2 files changed, 3 insertions(+) |
Created attachment 245449 [details] Patch for Realtek Killer Ethernet E2600 Hi, Realtek Killer Ethernet E2600 is not being recognized, hence cannot be configured. The device is successfully recognized, configured and working after adding few lines to sys/dev/re/if_re.c and sys/dev/rl/if_rlreg.h. This could help a lot of Gigabyte laptop users, as Killer Ethernet E2600 is very common for their 10th generation intel laptops. # dmesg | grep re0 re0: <RealTek Killer E2600 Gigabit Ethernet Controller> port 0x3000-0x30ff mem 0x58404000-0x58404fff,0x58400000-0x58403fff at device 0.0 on pci2 re0: Using 1 MSI-X message re0: ASPM disabled re0: Chip rev. 0x54000000 re0: MAC rev. 0x00100000 miibus0: <MII bus> on re0 re0: Using defaults for TSO: 65518/35/2048 re0: Ethernet address: 18:c0:4d:02:88:6f re0: netmap queues/slots: TX 1/256, RX 1/256 re0: link state changed to DOWN re0: link state changed to UP re0: link state changed to DOWN re0: link state changed to UP re0: link state changed to DOWN re0: link state changed to UP re0: link state changed to DOWN re0: link state changed to UP re0: link state changed to DOWN re0: link state changed to UP re0: link state changed to DOWN re0: link state changed to UP