Bug 274334

Summary: graphics/libgphoto2: fix build with lld 17
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (danfe)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 273753    
Attachments:
Description Flags
graphics/libgphoto2: fix build with lld 17 none

Description Dimitry Andric freebsd_committer freebsd_triage 2023-10-07 14:56:17 UTC 
Building graphics/libgphoto2 with lld 17 results in the following link
error:

  libtool: link: cc -shared  -fPIC -DPIC  .libs/libgphoto2_port_la-gphoto2-port-info-list.o .libs/libgphoto2_port_la-gphoto2-port-log.o .libs/libgphoto2_port_la-gphoto2-port-version.o .libs/libgphoto2_port_la-gphoto2-port.o .libs/libgphoto2_port_la-gphoto2-port-portability.o .libs/libgphoto2_port_la-gphoto2-port-result.o   -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/local/lib -L/usr/local/lib /usr/local/lib/libltdl.so -lintl -lpthread -lregex  -O2 -fstack-protector-strong -Wl,--version-script=./libgphoto2_port.ver -fstack-protector-strong -Wl,-rpath -Wl,/usr/local/lib   -Wl,-soname -Wl,libgphoto2_port.so.12 -o .libs/libgphoto2_port.so.12.0.0
  ld: error: version script assignment of 'LIBGPHOTO2_INTERNAL' to symbol 'gpi_gphoto_port_type_map' failed: symbol not defined
  cc: error: linker command failed with exit code 1 (use -v to see invocation)

The mentioned symbol has been removed from libgphoto2 a long time ago,
so remove it from the linker version script.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-10-07 14:56:37 UTC 
Created attachment 245484 [details]
graphics/libgphoto2: fix build with lld 17
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-21 10:57:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dee420703ee18ac8be9d10a488a3f650481aff78

commit dee420703ee18ac8be9d10a488a3f650481aff78
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-10-07 14:54:00 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-10-21 10:52:22 +0000

    graphics/libgphoto2: fix build with lld 17

    Building graphics/libgphoto2 with lld 17 results in the following link
    error:

      libtool: link: cc -shared  -fPIC -DPIC  .libs/libgphoto2_port_la-gphoto2-port-info-list.o .libs/libgphoto2_port_la-gphoto2-port-log.o .libs/libgphoto2_port_la-gphoto2-port-version.o .libs/libgphoto2_port_la-gphoto2-port.o .libs/libgphoto2_port_la-gphoto2-port-portability.o .libs/libgphoto2_port_la-gphoto2-port-result.o   -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/local/lib -L/usr/local/lib /usr/local/lib/libltdl.so -lintl -lpthread -lregex  -O2 -fstack-protector-strong -Wl,--version-script=./libgphoto2_port.ver -fstack-protector-strong -Wl,-rpath -Wl,/usr/local/lib   -Wl,-soname -Wl,libgphoto2_port.so.12 -o .libs/libgphoto2_port.so.12.0.0
      ld: error: version script assignment of 'LIBGPHOTO2_INTERNAL' to symbol 'gpi_gphoto_port_type_map' failed: symbol not defined
      cc: error: linker command failed with exit code 1 (use -v to see invocation)

    The mentioned symbol has been removed from libgphoto2 a long time ago,
    so remove it from the linker version script.

    PR:             274334
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2023Q4

 ...ibgphoto2__port_libgphoto2__port_libgphoto2__port.ver (new) | 10 ++++++++++
 1 file changed, 10 insertions(+)