Bug 274435

Summary: science/gromacs: Fix build
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me Flags: yuri: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for gromacs none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-10-12 18:21:23 UTC 
Created attachment 245584 [details]
Patch for gromacs

Switch MASTER_SITES to https
Fails to build with LLVM 14-17, switch to GCC instead

Reference:
https://github.com/Homebrew/homebrew-core/blob/c3174cdd90e026ce95010b725aa0a2f312d41bcd/Formula/g/gromacs.rb

Compile tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-10-12 21:41:27 UTC 
Thanks for the patch.

Approved.

Please commit it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-14 17:39:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c44e80aa1aeb28cda67e5eefb57285f67aef7b4

commit 6c44e80aa1aeb28cda67e5eefb57285f67aef7b4
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-10-14 17:34:46 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-10-14 17:38:19 +0000

    science/gromacs: Use https for MASTER_SITES and GCC for build

    - Switch MASTER_SITES to https
    - Fails to build with LLVM 14-17, use GCC instead

    Reference:
    https://github.com/Homebrew/homebrew-core/blob/c3174cdd90e026ce95010b725aa0a2f312d41bcd/Formula/g/gromacs.rb

    PR:             274435
    Reviewed by:    yuri (maintainer)

 science/gromacs/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-10-14 17:47:40 UTC 
Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-04 01:43:20 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c4ed455a4759caec5d71b92ddae5797383b52e99

commit c4ed455a4759caec5d71b92ddae5797383b52e99
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-10-14 17:34:46 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-11-04 01:42:33 +0000

    science/gromacs: Use https for MASTER_SITES and GCC for build

    - Switch MASTER_SITES to https
    - Fails to build with LLVM 14-17, use GCC instead

    Reference:
    https://github.com/Homebrew/homebrew-core/blob/c3174cdd90e026ce95010b725aa0a2f312d41bcd/Formula/g/gromacs.rb

    PR:             274435
    Reviewed by:    yuri (maintainer)

    (cherry picked from commit 6c44e80aa1aeb28cda67e5eefb57285f67aef7b4)

 science/gromacs/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)