Bug 274532
| Summary: | net-p2p/*arr: Switch back to converters/libiconv dependency | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michiel van Baak Jansen <michiel> | ||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | fernape, freebsd | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Triage: Reporter is Maintainer, assign to ports@ Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2170798e835f90876b763b641ef2f9bd9f75530a commit 2170798e835f90876b763b641ef2f9bd9f75530a Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-10-18 06:53:00 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-10-19 09:36:46 +0000 net-p2p/*arr: Switch back to converters/libiconv dependency In PR 274169 all *arr ports were switched to use 'USES+=libiconv' instead of a hard dependency on the 'converters/libiconv' port. Turns out, this is incorrect. Specifically 'libMonoPosixHelper' (part of .NET) is compiled against the port, and will break when the port is not installed (incompatible with the base version of libiconv) This patch moves all *arr ports back to RUN_DEPENDS on converters/libiconv PR: 274532 Reported by: michiel@vanbaak.eu (maintainer) net-p2p/lidarr/Makefile | 4 +++- net-p2p/prowlarr/Makefile | 5 +++-- net-p2p/radarr/Makefile | 4 +++- net-p2p/readarr/Makefile | 4 +++- net-p2p/sonarr-devel/Makefile | 4 +++- 5 files changed, 15 insertions(+), 6 deletions(-) |
Created attachment 245693 [details] 0001-net-p2p-arr-Switch-back-to-converters-libiconv-depen.patch In PR 274169 all *arr ports were switched to use 'USES+=libiconv' instead of a hard dependency on the 'converters/libiconv' port. Turns out, this is incorrect. Specifically 'libMonoPosixHelper' (part of .NET) is compiled against the port, and will break when the port is not installed (incompatible with the base version of libiconv) This patch moves all *arr ports back to RUN_DEPENDS on converters/libiconv poudriere ok Installed all updates on my setup (13.2 amd64) in production, and runs perfect. Affects the following ports net-p2p/lidarr net-p2p/prowlarr net-p2p/radarr net-p2p/readarr net-p2p/sonarr-devel Since I'm the maintainer of all, and the update is the same for all, I added them all in one patch, Same as the patch it undoes. Thanks to the servarr team for telling me about the error and explaining why the ports need the libiconv port instead of using the system iconv. patch by me.