Summary: | www/libnghttp3: Update to 1.3.0 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | eduardo | ||||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
URL: | https://github.com/ngtcp2/nghttp3/releases/tag/v1.3.0 | ||||||||||||
Attachments: |
|
Created attachment 246780 [details]
Patch for libnghttp3 v2
Created attachment 248647 [details]
Patch for libnghttp3 v3
Enable "make test"
Created attachment 250581 [details]
Patch for libnghttp3 v4
* Switch to CMake for faster builds
* Remove C++ requirements, we don't build anything that's written in C++
* Rearrange Makefile to follow Porters Handbook more closely and for readability
* Enable "make test"
Compile and runtime tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist, make test)
Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e670e294551e70e244f06997d37957680e955fb5 commit e670e294551e70e244f06997d37957680e955fb5 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-06-05 19:54:00 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-06-06 19:05:47 +0000 www/libnghttp3: Improve port * Switch to CMake for faster builds * Remove C++ requirements, we don't build anything that's written in C++ * Rearrange Makefile to follow Porters Handbook more closely and for readability * Enable "make test" PR: 274761 Approved by: portmgr (maintainer timeout, 3+ weeks) www/libnghttp3/Makefile | 16 ++++++++-------- www/libnghttp3/distinfo | 2 +- www/libnghttp3/files/patch-Makefile.in (gone) | 14 -------------- 3 files changed, 9 insertions(+), 23 deletions(-) As I said in other PR, I won't use cmake for such tiny library. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7ca6cad1091a2ca7e636e31af3005deaf2c0c552 commit 7ca6cad1091a2ca7e636e31af3005deaf2c0c552 Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2024-06-06 21:55:58 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2024-06-06 21:56:33 +0000 www/libnghttp3: Remove USES=compiler:c++17-lang PR: 274761 Reported by: diizzy www/libnghttp3/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) |
Created attachment 245930 [details] Patch for libnghttp3 * Switch to CMake for faster builds, it also additionally cleans up the port Makefile and removes the need for additional patching * Remove C++17 requirement, only C++14 is required * C++14 or C1++17 are default for all compilers we have in tree or base so no need to add CXXFLAGS * Rearrange Makefile to follow Porters Handbook more closely and for readability Compile tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist) Poudriere testport OK 12.4-RELEASE (amd64) Poudriere testport OK 13.2-RELEASE (amd64)