Bug 274821

Summary: net/quiche: update to 0.18.0
Product: Ports & Packages Reporter: Ralf van der Enden <tremere>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz, junho.choi
Priority: --- Flags: bugzilla: maintainer-feedback? (junho.choi)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/cloudflare/quiche/releases/tag/0.18.0
Attachments:
Description Flags
Update quiche to 0.18.0 tremere: maintainer-approval?

Description Ralf van der Enden 2023-10-30 21:42:50 UTC
Q&A:
poudriere: builds ok (13.2-RELEASE; amd64)
Makefile processed by portclippy/fmt

Full changelog: https://github.com/cloudflare/quiche/compare/0.12.0...0.18.0

Besides updating the port to 0.18.0 it also contains the following:
- enable CARGO_FEATURES ffi (required for enabling C/C++ bindings) and pkg-config-meta (which creates a quiche.pc for pkgconfig)
- pet portfmt

The next version of dns/dnsdist uses quiche for DNS-over-QUIC and fails to build without the ffi feature. The quiche.pc is a nice-to-have so I don't have to set variables to find the include and libs dirs.
Comment 1 Ralf van der Enden 2023-10-30 21:43:21 UTC
Created attachment 246006 [details]
Update quiche to 0.18.0
Comment 2 Junho Choi 2023-10-31 10:48:11 UTC
Comment on attachment 246006 [details]
Update quiche to 0.18.0

LGTM. Ship it! Thanks for updating.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-03 21:19:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e0bf86c63f160a098bd961b1884c044dd6dbfd3

commit 9e0bf86c63f160a098bd961b1884c044dd6dbfd3
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-10-30 21:35:08 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-03 21:09:44 +0000

    net/quiche: update to 0.18.0, move crates to Makefile.crates, pet portfmt, and more

    Changelog: https://github.com/cloudflare/quiche/compare/0.12.0...0.18.0

    PR:             274821
    Approved by:    junho.choi@gmail.com (maintainer)

 net/quiche/Makefile              | 102 +------------
 net/quiche/Makefile.crates (new) | 121 +++++++++++++++
 net/quiche/distinfo              | 322 +++++++++++++++++++++++----------------
 3 files changed, 321 insertions(+), 224 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-11-03 21:36:49 UTC
Thank you for your contribution.