Bug 27483
| Summary: | [sysinstall] [patch] make sysinstall ask for the keymap at installation time | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Cyrille Lefevre <clefevre> | ||||
| Component: | bin | Assignee: | freebsd-qa (Nobody) <qa> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | 4.3-STABLE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Cyrille Lefevre
2001-05-21 03:10:01 UTC
State Changed From-To: open->feedback I think that this will unnecessarily confuse new users. I don't recall other systems forcing users into a keymap selection menu. Are you sure this is really necessary? What do other systems do? I don't think they are this "in your face" about selecting a keymap, are they? I'm thinking in particular of Solaris and the last couple Linux distros I tried (I must admit its been a while). I think this may do more harm than good, in that it adds another potentially confusing menu for new users to go through. - Murray murray@FreeBSD.org wrote: > Synopsis: make sysinstall ask for the keymap at installation time > > State-Changed-From-To: open->feedback > State-Changed-By: murray > State-Changed-When: Wed Sep 5 00:50:18 PDT 2001 > State-Changed-Why: > I think that this will unnecessarily confuse new users. I don't recall > other systems forcing users into a keymap selection menu. are you sure ? how about windows, linux, solaris, hp-ux, etc. distributions ? they are all asking for keyboard language at the beginning of the installation process. > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27483 I've looked up the PR and my poboxes address seems to be dead. sorry. PS : teka care, freebsd-gnats-submit@FreeBSD.org is CCed. Cyrille. -- mailto:clefevre@citeweb.net State Changed From-To: feedback->closed Automatic feedback timeout. This PR remained unchanged in the feedback state for more than 4 months. If additional feedback that warrants the re-opening of this PR is available but not included in the audit trail, please include the feedback in a reply to this message (preserving the Subject line) and ask that the PR be re-opened. State Changed From-To: closed->open Feedback did actually arrive before it was closed. Submitter asks that this is reopened. Responsible Changed From-To: freebsd-bugs->freebsd-qa Over to maintainer group. Responsible Changed From-To: freebsd-qa->qa Use short names for mailing list to make searches using the web query form work with the shown responsible. This also makes open PRs show up in the summery mail. cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET 2004)
anyone to commit this PR ?
thanks in advance.
Index: main.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/main.c,v
retrieving revision 1.71
diff -u -I$Id.*$ -I$.+BSD.*$ -r1.71 main.c
--- main.c 20 Aug 2003 06:27:21 -0000 1.71
+++ main.c 3 Dec 2003 11:44:06 -0000
@@ -166,6 +166,8 @@
/* Begin user dialog at outer menu */
dialog_clear();
+ if (getpid() == 1)
+ dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
while (1) {
choice = scroll = curr = max = 0;
dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
Cyrille Lefevre
--
mailto:cyrille.lefevre@laposte.net
On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote: > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET 2004) > anyone to commit this PR ? > thanks in advance. > [snip] > /* Begin user dialog at outer menu */ > dialog_clear(); > + if (getpid() == 1) > + dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE); > while (1) { Just a minor comment: shouldn't RunningAsInit be used here instead of a getpid() invocation? :) G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@sbnd.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence contains exactly threee erors. > On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote: > > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET 2004) > > anyone to commit this PR ? > > thanks in advance. > > > [snip] > > /* Begin user dialog at outer menu */ > > dialog_clear(); > > + if (getpid() == 1) > > + dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE); > > while (1) { > > Just a minor comment: shouldn't RunningAsInit be used here instead of > a getpid() invocation? :) maybe, don't know in fact ? Cyrille Lefevre. -- home: mailto:cyrille.lefevre@laposte.net well, RunningAsInit is effectively more appropriate than getpid() == 1.
Index: main.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/main.c,v
retrieving revision 1.71
diff -u -I$Id.*$ -I$.+BSD.*$ -r1.71 main.c
--- main.c 20 Aug 2003 06:27:21 -0000 1.71
+++ main.c 15 Apr 2004 21:03:33 -0000
@@ -166,6 +166,8 @@
/* Begin user dialog at outer menu */
dialog_clear();
+ if (RunningAsInit)
+ dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
while (1) {
choice = scroll = curr = max = 0;
dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
Cyrille Lefevre
--
mailto:cyrille.lefevre@laposte.net
State Changed From-To: open->closed sysinstall has this functionality now. |
