Summary: | www/node16: Remove DTrace support to fix build with upcoming binutils 2.41 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||
Component: | Individual Port(s) | Assignee: | Yasuhiro Kimura <yasu> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | otis | ||||
Priority: | --- | Flags: | yasu:
maintainer-feedback-
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 272853 | ||||||
Attachments: |
|
Description
Yasuhiro Kimura
![]() ![]() Maintainer timeout. Take. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=441ef340afa6dd362be8029998f3327917b0670e commit 441ef340afa6dd362be8029998f3327917b0670e Author: Yasuhiro Kimura <yasu@FreeBSD.org> AuthorDate: 2023-11-01 09:00:55 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2023-11-18 00:27:06 +0000 www/node16: Remove DTrace support to fix build with upcoming binutils 2.41 * With binutils 2.41 build fails as following. LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.host:/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src/node_dtrace_ustack.o" dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name * This is because behaviour of objdump has changes with binutils 2.41. [1][2] * On upstream DTrace support itself has been removed with Node.js 19.x. * There is a pull request that says it fixes build error. [3] I tried it but unfortunately it doesn't work as is expected. * Upstream suggests me to remove DTrace support. [4] Reference: https://github.com/nodejs/node/issues/49991#issue-1920717730 [1] Reference: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2] Reference: https://github.com/nodejs/node/pull/49992 [3] Reference: https://github.com/nodejs/node/pull/49992#issuecomment-1784231190 [4] PR: 274846 Approved by: maintainer timeout www/node16/Makefile | 23 +++-------------------- www/node16/pkg-plist | 1 - 2 files changed, 3 insertions(+), 21 deletions(-) Thanks. This PR slipped out of my radar. |