Bug 274885

Summary: net/samba413 net/samba416: Make 'USES=shebangfix' work as is expected
Product: Ports & Packages Reporter: Yasuhiro Kimura <yasu>
Component: Individual Port(s)Assignee: Yasuhiro Kimura <yasu>
Status: Closed FIXED    
Severity: Affects Only Me CC: timur
Priority: --- Flags: yasu: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270383
Attachments:
Description Flags
Patch file none

Description Yasuhiro Kimura freebsd_committer freebsd_triage 2023-11-03 09:10:20 UTC 
Created attachment 246077 [details]
Patch file

While testing patch submitted to bug #270383, I noticed 'USES=shebangfix' doesn't work as is expected with current samba ports. According to the investigation by Tatsuki Makino, it is because SHEBANG_FILES is defined after bsd.port.options.mk and bsd.port.pre.mk are included. So fix the issue by moving the definition before the inclusion of them

Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004849.html
Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004852.html
Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004853.html
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2023-11-18 00:22:47 UTC 
Maintainer timeout. Take.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-18 00:30:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88d031b449271f1beb10d96ff344582429bfada9

commit 88d031b449271f1beb10d96ff344582429bfada9
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2023-11-03 08:59:50 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2023-11-18 00:27:23 +0000

    net/samba41[36]: Make 'USES=shebangfix' work as is expected

    While testing patch submitted to bug #270383, I noticed
    'USES=shebangfix' doesn't work as is expected with current samba
    ports. According to the investigation by Tatsuki Makino, it is because
    SHEBANG_FILES is defined after bsd.port.options.mk and bsd.port.pre.mk
    are included. So fix the issue by moving the definition before the
    inclusion of them

    Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004849.html
    Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004852.html
    Reference:      https://lists.freebsd.org/archives/freebsd-ports/2023-November/004853.html
    PR:             274885
    Approved by:    maintainer timeout

 net/samba413/Makefile | 10 +++++-----
 net/samba416/Makefile | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)