Bug 274907

Summary: net/krill Update to version 0.14.2 (was 0.14.1)
Product: Ports & Packages Reporter: Jaap Akkerhuis <jaap>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: fuz
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/NLnetLabs/krill/releases/tag/v0.14.1
Attachments:
Description Flags
Patch to upgrade
jaap: maintainer-approval+
patch to upgrade
jaap: maintainer-approval+
corrected patch to update jaap: maintainer-approval+

Description Jaap Akkerhuis 2023-11-04 14:29:55 UTC
Created attachment 246109 [details]
Patch to upgrade

This update includes 0.14.0 'ASPA'

Extra, Extra! Latest

This release fixes a bug in the migration code where 'surplus'
directories for archived events should be skipped (#1147).

Release 0.14.0 'ASPA' adds support for the updated ASPA v1 profile
(issue #1080). Any existing ASPA objects will be re-issued
automatically. Updated documentation can be found here.

In addition, the following small features and fixes were done:

Show delete ROA button when no BGP preview is available #1139

o Add traditional and simplified Chinese translations #1075
o Let the testbed automatically renew the TA manifest and CRL #1095
  (see below)
o Show the delete icon for AS0 ROA when there is another existing
  announcement #1109
o The main effort in this release was spent on less user-visible
  improvements in how Krill stores its data. This will help improve
  robustness today and pave the way for introducing support for Krill
  clustering using a database back-end in a future release.

For now, these issues have been done:

o Improve transactionality of changes (e.g. #1076-1078, #1085, #1108, #1090)
o Remove no longer needed 'always_recover_data' function #1086
o Improve upgrade failed error: tell users to downgrade #1042
o Crash Krill if the task scheduler encounters a fatal error. #1132

You can find the full list of issues here: https://github.com/NLnetLabs/krill/projects/25

Finally, regarding issue #1095. If you were running 0.13.1 as a
testbed, you might have symlinked the "signer" directory to "ta_signer"
to support a manual workaround for re-signing the trust anchor CRL
and manifest. If you did, you may need to delete any surplus files
and directories under "data/ta_signer" other than the " ta "
directory.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-11-04 18:25:44 UTC
(In reply to Jaap Akkerhuis from comment #0)

> Finally, regarding issue #1095. If you were running 0.13.1 as a
> testbed, you might have symlinked the "signer" directory to "ta_signer"
> to support a manual workaround for re-signing the trust anchor CRL
> and manifest. If you did, you may need to delete any surplus files
> and directories under "data/ta_signer" other than the " ta "
> directory.

If you believe this is appropriate, please check if you could add a note to
UPDATING about this issue.  If not, just let me know and I commit the patch as is.  If yes, just post the not as a comment and I'll add it on commit.
Comment 2 Jaap Akkerhuis 2023-11-04 19:45:10 UTC
(In reply to Robert Clausecker from comment #1)
I don't think it is necessary to have a note in UPDATING about this.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-11-04 21:05:41 UTC
Great, thanks for letting me know.
Comment 4 Jaap Akkerhuis 2023-11-06 12:32:17 UTC
I just heard that there is yet another bug found and that there is a new release. Sigh. Let's stop this version and wait for the next release.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-11-06 22:00:20 UTC
Okay.  I'll drop the patch from my current batch.  Please let me know when you are ready for a new patch.
Comment 6 Jaap Akkerhuis 2023-11-08 12:18:29 UTC
Created attachment 246194 [details]
patch to upgrade

For version 0.14.2

This release fixes a bug in the migration code, not fully fixed in 0.14.1, where 'surplus' archived data should be skipped (#1147). There is no need to upgrade to this version if you already upgraded to 0.14.0 or 0.14.1.
Comment 7 Jaap Akkerhuis 2023-11-08 12:20:18 UTC
(In reply to Robert Clausecker from comment #5)
Added improved patch for version 0.14.2
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-11-08 20:22:40 UTC
Thank you for the updae.

Please check the following warnings indicated for the port:

/!\ krill-0.14.2: Makefile warnings, please consider fixing /!\

Please make sure this port uses the system OpenSSL and consider removing
CARGO_CRATES=openssl-src-111.25.3+1.1.1t (a vendored copy of OpenSSL) from
the build, e.g., by patching Cargo.toml appropriately.

Is it possible to just remove the crate?
Comment 9 Jaap Akkerhuis 2023-11-08 21:10:19 UTC
(In reply to Robert Clausecker from comment #8)
Argh! I completely forgot this. Apologies
Just removing this from the crate ain't enough, there also need a patch for Cargo.toml. Let me send you an improved patch tomorrow (in a conf call on the moment).
Comment 10 Jaap Akkerhuis 2023-11-09 11:57:16 UTC
Created attachment 246213 [details]
corrected patch to update

Now with a correct Makefile.crates and corresponding patch for Cargo.toml
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-11-09 16:11:19 UTC
Looking good!
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-11-12 04:30:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f72b97af8e856e68f5419287f25e74fcaaf1ff4f

commit f72b97af8e856e68f5419287f25e74fcaaf1ff4f
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2023-11-09 11:42:50 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-12 01:36:25 +0000

    net/krill: Update to Version 0.14.2

    Changelog: https://github.com/NLnetLabs/krill/releases/tag/v0.14.1
    Changelog: https://github.com/NLnetLabs/krill/releases/tag/v0.14.2

    PR:             274907

 net/krill/Makefile                        |  3 +-
 net/krill/Makefile.crates                 | 32 +++++++++++---
 net/krill/distinfo                        | 72 +++++++++++++++++++++++--------
 net/krill/files/patch-Cargo.toml          | 20 ++++-----
 net/krill/files/patch-defaults_krill.conf | 19 +++++---
 5 files changed, 104 insertions(+), 42 deletions(-)
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2023-11-12 04:34:21 UTC
Thank you for your contribution.