Bug 274920

Summary: devel/open62541: Update to version 1.3.9
Product: Ports & Packages Reporter: Nico Sonack <nsonack>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy
Priority: --- Flags: nsonack: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/open62541/open62541/releases/tag/v1.3.9
Attachments:
Description Flags
Patch for updating the port
nsonack: maintainer-approval+
Patch v2 (now for version 1.3.9) nsonack: maintainer-approval+

Description Nico Sonack 2023-11-04 20:19:11 UTC 
Created attachment 246131 [details]
Patch for updating the port

Built and tested in Poudriere against 13.2-RELEASE amd64.

The manual patch for CMakeLists.txt can be removed as the new version announces its version correctly and doesn't produce incorrectly named shared objects.
See https://github.com/open62541/open62541/issues/6010
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-11-04 22:56:40 UTC 
Any objections about adding CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_Git (mainly to remove the possibility that it does something bad with git installed) and removing BINARY_ALIAS?
Comment 2 Nico Sonack 2023-11-05 11:11:58 UTC 
(In reply to Daniel Engberg from comment #1)

No objections about the git thing. I am unsure if it will still build with the BINARY_ALIAS removed unless this has been resolved otherwise.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-11-05 11:54:36 UTC 
Work as done "recently" regarding CMake and Python so it actually works fine in most cases as long as python3 isn't hardcoded.
https://cgit.freebsd.org/ports/commit/Mk/Uses/python.mk?id=aa9736e3e5f6856f5eb5e26837169b0f6022eec8

It passes Poudriere on my end
Comment 4 Nico Sonack 2023-11-05 12:57:35 UTC 
(In reply to Daniel Engberg from comment #3)

Good to know! Thank you.

In that case I'm fine with the change.
Comment 5 Nico Sonack 2023-12-08 17:10:06 UTC 
Created attachment 246910 [details]
Patch v2 (now for version 1.3.9)

Patch updated for suggested changes.

I also updated to the in the meantime released version 1.3.9 too.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-12-30 16:22:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cbaa671a45c1dd43897844bd364a19ccddcb70dc

commit cbaa671a45c1dd43897844bd364a19ccddcb70dc
Author:     Nico Sonack <nsonack@outlook.com>
AuthorDate: 2023-12-28 19:22:33 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-12-30 16:22:13 +0000

    devel/open62541: Update to 1.3.9

    Changelog: https://github.com/open62541/open62541/releases/tag/v1.3.9

    PR:             274920

 devel/open62541/Makefile                          |  6 +++---
 devel/open62541/distinfo                          |  6 +++---
 devel/open62541/files/patch-CMakeLists.txt (gone) | 11 -----------
 3 files changed, 6 insertions(+), 17 deletions(-)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-12-30 16:23:04 UTC 
Commmited, thanks!