Bug 274937

Summary: www/chromium build failure for chromium-119.0.6045.105 under stable/12
Product: Ports & Packages Reporter: david
Component: Individual Port(s)Assignee: freebsd-chromium (Nobody) <chromium>
Status: Closed FIXED    
Severity: Affects Some People CC: rnagy
Priority: --- Flags: bugzilla: maintainer-feedback? (chromium)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
gzipped copy of a poudriere build log, showing the build failure none

Description david 2023-11-06 12:45:18 UTC 
Created attachment 246159 [details]
gzipped copy of a poudriere build log, showing the build failure

This is running:
FreeBSD freebeast.catwhisker.org 12.4-STABLE FreeBSD 12.4-STABLE #270 stable/12-n236319-ee4bdd4b0db5: Fri Nov  3 11:18:07 UTC 2023     root@freebeast.catwhisker.org:/common/S1/obj/usr/src/amd64.amd64/sys/GENERIC  amd64 1204500 1204500

with a ports tree at main-n639216-c83f22d493f0, building using pouderiere-devel.

I have attached a gzipped copy of the build log; a salient excerpt is:

...
[ 25% 14401/57063] c++ -MMD -MF obj/base/base/sysctl.o.d -DBASE_IMPLEMENTATION -DIS_RAW_PTR_IMPL -DSYSTEM_NATIVE_UTF8 -DUSE_SYMBOLIZE -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DBASE_USE_PERFETTO_CLIENT_LIBRARY=1 -DUSE_SYSTEM_LIBEVENT=1 -DGLOG_EXPORT= -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DU_FINAL=final -DU_NOEXCEPT=noexcept -DU_OVERRIDE=override -DU_IMPORT=U_EXPORT -I../.. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/libevent_shim -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -g0 -fprofile-use=../../chrome/build/pgo_profiles/chrome-linux-6045-1698664371-1ead1dca80625bea68dc6db59678d57af8496186.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wshorten-64-to-32 -Wimplicit-int-conversion -Wsign-compare -Wsign-conversion -Wtautological-unsigned-zero-compare -Wexit-time-destructors -Wglobal-constructors -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-math-errno -DPROTOBUF_ALLOW_DEPRECATED=1 -I/usr/local/include -I/usr/local/include -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -c ../../base/posix/sysctl.cc -o obj/base/base/sysctl.o
FAILED: obj/base/base/sysctl.o
c++ -MMD -MF obj/base/base/sysctl.o.d -DBASE_IMPLEMENTATION -DIS_RAW_PTR_IMPL -DSYSTEM_NATIVE_UTF8 -DUSE_SYMBOLIZE -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DBASE_USE_PERFETTO_CLIENT_LIBRARY=1 -DUSE_SYSTEM_LIBEVENT=1 -DGLOG_EXPORT= -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DU_FINAL=final -DU_NOEXCEPT=noexcept -DU_OVERRIDE=override -DU_IMPORT=U_EXPORT -I../.. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/libevent_shim -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -g0 -fprofile-use=../../chrome/build/pgo_profiles/chrome-linux-6045-1698664371-1ead1dca80625bea68dc6db59678d57af8496186.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wshorten-64-to-32 -Wimplicit-int-conversion -Wsign-compare -Wsign-conversion -Wtautological-unsigned-zero-compare -Wexit-time-destructors -Wglobal-constructors -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-math-errno -DPROTOBUF_ALLOW_DEPRECATED=1 -I/usr/local/include -I/usr/local/include -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -c ../../base/posix/sysctl.cc -o obj/base/base/sysctl.o
In file included from ../../base/posix/sysctl.cc:7:
/usr/include/sys/sysctl.h:1117:25: error: unknown type name 'u_int'
int     sysctl(const int *, u_int, void *, size_t *, const void *, size_t);
                            ^
../../base/posix/sysctl.cc:45:10: error: no matching function for call to 'StringSysctlImpl'
  return StringSysctlImpl([mib](char* out, size_t* out_len) {
         ^~~~~~~~~~~~~~~~
../../base/posix/sysctl.cc:20:29: note: candidate function not viable: no known conversion from '(lambda at ../../base/posix/sysctl.cc:45:27)' to 'base::FunctionRef<int (char *, size_t *)>' (aka 'FunctionRef<int (char *, unsigned long *)>') for 1st argument
absl::optional<std::string> StringSysctlImpl(
                            ^
2 errors generated.


Building under
FreeBSD 13.2-STABLE #425 stable/13-n256670-550f632c11c1: Sun Nov  5 12:59:22 UTC 2023     root@freebeast.catwhisker.org:/common/S3/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1302508 1302508

(stable/13) succeeds.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-06 14:18:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bade8088697e8ced11f37cc3d63d900f6b4b6301

commit bade8088697e8ced11f37cc3d63d900f6b4b6301
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-11-06 14:15:59 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-11-06 14:17:08 +0000

    www/*chromium: sysctl(2) requires sys/types.h to be included

    PR:     274937

 www/chromium/files/patch-base_posix_sysctl.cc (new)           | 10 ++++++++++
 www/ungoogled-chromium/files/patch-base_posix_sysctl.cc (new) | 10 ++++++++++
 2 files changed, 20 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-06 14:18:10 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df4a5af9e35d8fa884f968d97a0db06a34aa65ff

commit df4a5af9e35d8fa884f968d97a0db06a34aa65ff
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-11-06 14:15:59 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-11-06 14:17:32 +0000

    www/*chromium: sysctl(2) requires sys/types.h to be included

    PR:     274937
    (cherry picked from commit bade8088697e8ced11f37cc3d63d900f6b4b6301)

 www/chromium/files/patch-base_posix_sysctl.cc (new)           | 10 ++++++++++
 www/ungoogled-chromium/files/patch-base_posix_sysctl.cc (new) | 10 ++++++++++
 2 files changed, 20 insertions(+)