Summary: | sysutils/bastille: do not override upstream rc script | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Denis Shaposhnikov <dsh> | ||||
Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | christer.edwards, fernape, freebsd, michaelo | ||||
Priority: | --- | Flags: | fernape:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Denis Shaposhnikov
2023-11-09 16:20:18 UTC
you're Trink that should be the default, instead of some variable that needs to be set This is the wrong forum. Go here: https://github.com/BastilleBSD/bastille/issues rc.d/bastille is part of freebsd port: https://cgit.freebsd.org/ports/tree/sysutils/bastille/files/bastille.in so this is correct forum. the upstream script was fixed to support this a year ago maybe we should drop our override? I agree. Looking into https://github.com/BastilleBSD/bastille/blob/master/usr/local/etc/rc.d/bastille I don't see why does sysutils/bastille override upstream's rc.d script. We can standardize the upstream if you can show me an example / patch. I'm not tied to the current method for any reason. see discussion https://github.com/BastilleBSD/bastille/issues/389 discussion fix: https://github.com/BastilleBSD/bastille/pull/556 this still leaves the recent problem mentioned in https://github.com/BastilleBSD/bastille/issues/389#issuecomment-1782623047 I just created PR https://github.com/BastilleBSD/bastille/pull/629 which allows configuring dependencies between jails. May be this way is better. (In reply to Denis Shaposhnikov from comment #3) It is not :-) Our issue tracker is used for issues identified to be bugs and enhancements. For general support, questions and issues, the following channels are available to the community: https://www.freebsd.org/support.html If your issue is isolated to be a bug and is reproducible on an up-to-date and supported FreeBSD version, please re-open this issue with additional information and steps to reproduce. This is a bug. Jails should be stopped in reverse order. And this bug is specific for the port, because the startup script is part of this port. And this bug is fixed upstream, so this is a bug of this port. (In reply to Denis Shaposhnikov from comment #10) Then, let's do things properly. Oh, thanks. You are right, this title is better. Created attachment 246723 [details]
update to 0.10.20231125
This patch updates bastille to latest release 0.10.20231125
Also it uses upstream rc script, instead of one from port's files dir.
Comment on attachment 246723 [details]
update to 0.10.20231125
Thank you. This was on my todo list.
(In reply to Christer Edwards from comment #14) Hi Chris, can I assume you approve this patch? (it is still queued for testing on my side sorry). approved Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=08ed7d01655c4150a96e1c49bdab87711a952df4 commit 08ed7d01655c4150a96e1c49bdab87711a952df4 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-12-06 18:54:08 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-12-07 19:25:47 +0000 sysutils/bastille: update to 0.10.20231125 While here do not override upstream rc script PR: 274993 Reported by: dsh@bamus.cz Approved by: christer.edwards@gmail.com (maintainer) sysutils/bastille/Makefile | 22 +++++++---- sysutils/bastille/distinfo | 6 +-- sysutils/bastille/files/bastille.in (gone) | 61 ------------------------------ sysutils/bastille/pkg-plist | 2 + 4 files changed, 20 insertions(+), 71 deletions(-) |