Bug 275118
| Summary: | x11-wm/amiwm: update to 0.22pl2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Buck Duck <rolodeovo> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | cy, dcarmich, diizzy, fernape | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(dcarmich) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
^Triage: rework title. ^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Q/A: PORTREVISION should be removed. NO NEED to update a new patch. Buck, Could you have a look? ===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=root UID=0 GID=0 ===> amiwm-0.22.pl2 depends on file: /usr/local/sbin/pkg - found => amiwm0.22pl2.tar.gz doesn't seem to exist in /portdistfiles/. => Attempting to fetch ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz fetch: ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz: Protocol error => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/amiwm0.22pl2.tar.gz fetch: http://distcache.FreeBSD.org/ports-distfiles/amiwm0.22pl2.tar.gz: Not Found => Couldn't fetch it - please try to retrieve this => port manually into /portdistfiles/ and try again. *** Error code 1 (In reply to Fernando Apesteguía from comment #3) Strange.. i was able to successfully compile the window manager and even manually fetch the source code. Didn't change much either, just the PORTVERSION and pkg-plist. I'll attach the revised diff with PORTREVISION removed. Created attachment 246379 [details]
amiwm.diff
I just tried again. I'm unable to fetch. With fetch(1), it gives protocol error. Manually with wget, I get: $ wget ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz --2023-11-18 17:55:43-- ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz => ‘amiwm0.22pl2.tar.gz’ Resolving ftp.lysator.liu.se (ftp.lysator.liu.se)... 130.236.254.251, 130.236.254.253, 2001:6b0:17:f0a0::fd, ... Connecting to ftp.lysator.liu.se (ftp.lysator.liu.se)|130.236.254.251|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (1) /pub/X11/wm/amiwm ... done. ==> SIZE amiwm0.22pl2.tar.gz ... 193340 ==> PASV ... done. ==> RETR amiwm0.22pl2.tar.gz ... Error in server response, closing control connection. Retrying. Only curl seems to be able to get this: curl -vvv -o test ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0* Trying 130.236.254.251:21... * Connected to ftp.lysator.liu.se (130.236.254.251) port 21 < 220-Welcome to Lysator's FTP server! < 220 Only anonymous FTP is allowed here > USER anonymous < 230 Anonymous user logged in > PWD < 257 "/" is your current location * Entry path is '/' > CWD pub * ftp_perform ends with SECONDARY: 0 < 250 OK. Current directory is /pub > CWD X11 < 250 OK. Current directory is /pub/X11 > CWD wm < 250 OK. Current directory is /pub/X11/wm > CWD amiwm < 250 OK. Current directory is /pub/X11/wm/amiwm > EPSV * Connect data stream passively < 229 Extended Passive mode OK (|||52966|) * Connecting to 130.236.254.251 (130.236.254.251) port 52966 0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--:-- 0* Trying 130.236.254.251:52966... * Connected to ftp.lysator.liu.se (130.236.254.251) port 21 > TYPE I < 200 TYPE is now 8-bit binary > SIZE amiwm0.22pl2.tar.gz < 213 193340 > RETR amiwm0.22pl2.tar.gz < 150-Accepted data connection < 150 188.8 kbytes to download * Maxdownload = -1 * Getting file with size: 193340 { [1440 bytes data] * Remembering we are in dir "pub/X11/wm/amiwm/" < 226-File successfully transferred < 226 0.001 seconds (measured here), 128.40 Mbytes per second 100 188k 100 188k 0 0 70493 0 0:00:02 0:00:02 --:--:-- 70484 * Connection #0 to host ftp.lysator.liu.se left intact Stop using ftp in 2024? :-) https://hina.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz https://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz Works just fine, Best regards, Daniel There's something wrong with the fetch command itself too: slippy$ fetch --no-passive 'ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz' fetch: ftp://ftp.lysator.liu.se/pub/X11/wm/amiwm/amiwm0.22pl2.tar.gz: Syntax error, command unrecognized slippy$ Now, regarding the hang, this is usually indicative of an FTP server behind a firewall. But this isn't the case here. Passive FTP does work. This is clearly a problem within libfetch. With another unrelated problem in fetch(1) itself. And agreed, we shouldn't use FTP. Mozilla and Google have not only deprecated FTP in their browsers but totally removed it. But in the mean time, as long as fetch(1) and fetch(3) are documented to support FTP they should be fixed. Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=80cbb68192e76f434ca7dbe3bfca4cb1a3674801 commit 80cbb68192e76f434ca7dbe3bfca4cb1a3674801 Author: Buck Duck <rolodeovo@yandex.com> AuthorDate: 2023-11-17 07:46:54 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-01-07 17:49:11 +0000 x11-wm/amiwm: update to 0.22pl2 PR: 275118 Reported by: rolodeovo@yandex.com Approved by: dcarmich@dcarmichael.net (maintainer, timeout > 2 weeks) x11-wm/amiwm/Makefile | 7 +++---- x11-wm/amiwm/distinfo | 5 +++-- x11-wm/amiwm/pkg-plist | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) |
Created attachment 246343 [details] 0001-Updated-to-0.22pl2.patch I have updated x11-wm/amiwm to version 0.22pl2. This one also includes the previously missing Launcher module. The patch has been attached.