Bug 275143
| Summary: | [NEW PORT] audio/atracdenc: ATRAC1, ATRAC3 compatible encoder with LGPL licence | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | dan.cherednik | ||||||||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | diizzy | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
dan.cherednik
2023-11-16 22:15:07 UTC
Hi, Some initial thoughts Github URL returns 404, the cgit site generates a snapshot on the fly as far as I know so it would be great if you could create a release and upload a static release archive on GitHub (see also https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/ ). Do you think we can unbundle G(oogle)test and use the port instead? https://www.freshports.org/devel/googletest/ Best regards, Daniel (In reply to Daniel Engberg from comment #1) Thank you for your prompt reply. About cgit. You right, tgz was being generated on the fly. I've changed the url and put file as static on my mirror. I will add a new shar. Thank you. About github. I've already add static release archive. The url is https://github.com/dcherednik/atracdenc/releases/download/0.1.0/atracdenc-0.1.0.tar.gz and as far as i know MASTER_SITES= https://github.com/dcherednik/atracdenc/releases/download/${DISTVERSION}/ should handle it (it works in my environment). Please let me known if I missing something. About gtest. So... I can add a patch in to this port to use library from the ports tree... But do we really want it? Other option is to add gtest dependencies just in to the main repository (and remove gtest from source code), but it will make development on platforms without packet managers a bit more complicated. I can make an Issue and replace gtest with some lightweight header only library (FCTX for example) in the next release of atracdenc. Probably it is the best way for me. Kind regards. Created attachment 246380 [details]
atracdenc shar. Fixed MASTER_SITES url
(In reply to dan.cherednik from comment #2) Nitpick about MASTER_SITES but I think it's better to default to GitHub due to availability and performance and fallback to your site if it fails. Regarding gtest, the general recommendation is to follow Porters Handbook (https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs). You seem to be the upstream author so perhaps make CMake look for an installed version of gtest and fallback to builtin variant if not found? While shar files are acceptable please consider submitting patch files instead. Created attachment 246431 [details]
Use gtest, change MASTER_SITES priority
Ok. Please consider the following patch. I have changed MASTER_SITES order, removed gtest from upstream, added devel/googletest instead.
PS: Are there any recommendations how to generate diff to make it easy to apply, for example use git format patch, or just diff between two folders is fine?
Best regards.
Created attachment 246454 [details]
Patch for atracdenc
Remove menu option and a few other tweaks
(In reply to dan.cherednik from comment #5) Hi, If you supply one without any metadata (git diff) that's fine but you can also use git format. Please make sure it applies cleanly and don't depend on any previous patches. Best regards, Daniel (In reply to Daniel Engberg from comment #6) It works! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5ee7d6a649a175c22e5321e9b0587ee2c0744a12 commit 5ee7d6a649a175c22e5321e9b0587ee2c0744a12 Author: Daniil Cherednik <dan.cherednik@gmail.com> AuthorDate: 2023-11-24 17:36:43 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-11-24 17:36:51 +0000 audio/atracdenc: New port: ATRAC1 decoder/encoder, ATRAC3 encoder Audio encoder that supports ATRAC1 and ATRAC3 formats, can decode ATRAC1 and supports following containers: AEA, OMA, RIFF, RealMedia. WWW: https://github.com/dcherednik/atracdenc/ PR: 275143 audio/Makefile | 1 + audio/atracdenc/Makefile (new) | 29 +++++++++++++++++++++++++++++ audio/atracdenc/distinfo (new) | 3 +++ audio/atracdenc/pkg-descr (new) | 2 ++ 4 files changed, 35 insertions(+) Committed, thanks! |
